Date: Wed, 21 Mar 2001 14:39:23 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Andre Oppermann <oppermann@monzoon.net> Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: conf/25577: [PATCH] ifconfig support for wireless network cards Message-ID: <20010321143923.C7887@Odin.AC.HMC.Edu> In-Reply-To: <200103212220.f2LMK2g31484@freefall.freebsd.org>; from oppermann@monzoon.net on Wed, Mar 21, 2001 at 02:20:02PM -0800 References: <200103212220.f2LMK2g31484@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0vzXIDBeUiKkjNJl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 21, 2001 at 02:20:02PM -0800, Andre Oppermann wrote: > At least the drivers are very similiar and share a lot of the same > base functions. > > The question is more of a policy sort. Is it better to have two > similiar drivers or one driver with more conditional code? It depends. If combining them reduces the features of either driver, I'm absolutly against it. On the other hand if you can save substantial code by combining them and you don't lose functionality then it's probably OK. The thing is, I don't think you can combine them without losing functionality. It might be better to look for code that can be pushed into a kernel support library. Please don't take this as a slight to your work, but I'm mostly concerned that this change not get tied into a larger driver rework effort. I don't think this change would negativly impact such a project if it were comitted and I don't want things to stall due to circumstances beyond my control. I'm fairly neutral on the idea of combination in the abstract though I will note that down that road lies the Linux eth0 for good or ill. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --0vzXIDBeUiKkjNJl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6uS2aXY6L6fI4GtQRAmgzAJ9H2f9GbtlQyxVblE0ePMe3JoiZFACg0aRM zDG72bi+FlZfZTxikYh6FQ4= =pp1Q -----END PGP SIGNATURE----- --0vzXIDBeUiKkjNJl-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010321143923.C7887>