Date: Wed, 28 Dec 2011 09:59:13 -0800 From: Doug Barton <dougb@FreeBSD.org> To: =?windows-1252?Q?Ulrich_Sp=F6rlein?= <uqs@spoerlein.net>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r228909 - head/games/fortune/datfiles Message-ID: <4EFB58F1.6020206@FreeBSD.org> In-Reply-To: <20111228155340.GE83814@acme.spoerlein.net> References: <201112271021.pBRALvxB048644@svn.freebsd.org> <20111228155340.GE83814@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/28/2011 07:53, Ulrich Spörlein wrote: > On Tue, 2011-12-27 at 10:21:57 +0000, Doug Barton wrote: >> Author: dougb >> Date: Tue Dec 27 10:21:57 2011 >> New Revision: 228909 >> URL: http://svn.freebsd.org/changeset/base/228909 >> >> Log: >> 1. Remove a bunch of duplicates. Usually this means removing them from >> fortunes, but occasionally remove them from the other 2 files when >> they are not offensive, or not murphy'ish enough. >> >> Where the version in fortunes had better attribution and/or formatting, >> copy it over. >> >> 2. Fix a few typos >> >> 3. Use the full name of François De La Rochefoucauld, fix one of his >> quotes, and remove the duplicate of it. > > Sigh, > > except for a stupid Unicode version of an apostrophe ( vs ') That seems like an easy thing to fix? > this file > was ASCII. And I made it so for a reason. We don't currently have a way > to iconv fortune(6)'s output to the users LC_CTYPE. ASCII is the common > denominator so that's what we have to choose to be bug free. What breaks for non-ASCII text? > My plan was to teach fortune to use bsdiconv once that is ready and in > the tree to convert from Unicode to the users' locale. But until that is > ready, we have to stick to ASCII. I'm not opposed to doing that, but I want to make sure that a) it's for a good reason, and b) that we have some way to know what needs to be added back when it's safe. Meanwhile, I did actually test this change and it worked for me, so I thought it was safe to proceed. > This is not a backout request, I've no objection to making a change. Apparently the De should be de anyway, so what do you suggest? Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EFB58F1.6020206>