Date: Sun, 02 Dec 2012 08:21:50 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: yanegomi@gmail.com Cc: rc@FreeBSD.org, current@FreeBSD.org Subject: Re: RFC: sysctl -f filename Message-ID: <20121202.082150.896017277887885294.hrs@allbsd.org> In-Reply-To: <CAGH67wShpcmOKhc09%2BMP5c-AOm7EAPG%2BGqv=J0PRq0sGuTzKRQ@mail.gmail.com> References: <20121202.015048.1122480556487090170.hrs@allbsd.org> <CAGH67wTC50X1M2uUo0g=Nm6PmpOXPzYnp4tbXDCQyA9eOKB%2B7Q@mail.gmail.com> <CAGH67wShpcmOKhc09%2BMP5c-AOm7EAPG%2BGqv=J0PRq0sGuTzKRQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Garrett Cooper <yanegomi@gmail.com> wrote in <CAGH67wShpcmOKhc09+MP5c-AOm7EAPG+Gqv=J0PRq0sGuTzKRQ@mail.gmail.com>: ya> On Sat, Dec 1, 2012 at 2:10 PM, Garrett Cooper <yanegomi@gmail.com> wrote: ya> > Why change the tool when we can change the rc script to do the ya> > right thing? I have a patch I'm working on to resolve this (you hit an ya> > itch I've been meaning to scratch for a little while). ya> ya> This should work. I also refactored the script to get it down to ya> 80 columns. I've attached the debug output and the diff for the debug ya> version of the script. You will find out the following test case does not work (this is one of the test strings I used): kern.domainname="c$EDITOR.\"\ hoge\ \"\#hoge2\\$ \# h$$\#oge"# The reason why I changed sysctl(8) was that the rc.d/sysctl script was too complex and slow even if it could support meta characters in shell script syntax. I created several prototypes as script but noticed that keeping consistency was quite difficult and maintainability was poor due to tricky handling of variables. Although my patch in the previous email does not support meta characters completely, I still think it is more reasonable to implement this functionality on the sysctl(8) side. -- Hiroki ----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlC6kQ4ACgkQTyzT2CeTzy1sjQCguq+9gj8qNTMzQJbV1uVmyoCL RagAoNktNXOzlZuAk5aZC9Ax7MH0oyiN =ZWBX -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121202.082150.896017277887885294.hrs>