Date: Tue, 24 Jun 2014 14:38:50 -0700 From: Warner Losh <imp@bsdimp.com> To: Andrey Chernov <ache@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r267758 - head Message-ID: <CF27A000-1187-469F-AD2C-88D2BDFF797F@bsdimp.com> In-Reply-To: <DF5BDC7F-70A9-4707-BAFD-0530C6134F61@bsdimp.com> References: <201406230054.s5N0suIA081734@svn.freebsd.org> <256E890F-9564-4741-A5D8-89543381CF2D@gmail.com> <53A9B494.3020709@freebsd.org> <DF5BDC7F-70A9-4707-BAFD-0530C6134F61@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Jun 24, 2014, at 2:26 PM, Warner Losh <imp@bsdimp.com> wrote:
>
> On Jun 24, 2014, at 10:25 AM, Andrey Chernov <ache@freebsd.org> wrote:
>
>> On 24.06.2014 20:07, Warner Losh wrote:
>>>> Log:
>>>> Change suggestion how to set MAKESYSPATH as broken incremental build
>>>> workaround. Magic ".../share/mk" (search directories up to /)
>>>> does not work for f.e. /usr/src/gnu/lib/libgcc because the path
>>>> inside is starting from /usr/obj hierarchy and ends up in
>>>> /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is.
>>>> IMHO proper fixing of incremental build is needed urgently.
>>>
>>> I don’t understand how this is even possible. This change is wrong because it has a bogus path the doesn’t exist on all systems. I’m going to fix that.
>>
>> How it is possible:
>> cd /usr/src/gnu/lib/libgcc
>> make
>
> This does a recursive make, with pwd in /usr/obj…. That’s going to be utterly evil to fix…
Actually, adding a simple cd ${.CURDIR} before the make fixes this… We need to do it in 3 places.
# one could argue that we should just .include something to make unwind.h instead of this rube-goldberg reach over make…
# and I’d agree with them...
Warner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJTqe/qAAoJEGwc0Sh9sBEAEekP/iHxfh4e2UMLiFsYqqOtpjMs
tQCz1hiIYSf9ilDuvod8WrhqNO23QKWIkRgvmC+ctfADNIe/V51LZTuR858RHsiF
mBNJsmPOh9u2IOX1kSmCHMxNrJFWH6y4T9Xe4NFrtARC6qvSxlcuvkmgfqzEmdCe
CkVXurajIEnWvtXSCG1cwfj+BngSFezCUWoAT7+2cYqI8WSHfk9+SrrCdoTJ9ul3
c7bF4DzHMp/RUrm88UpxwbRo+t+dnRT0WdWJ4/uCR+mi9JewFHOd9JJbA9GAWgUv
IKFDtthvFAmkomPStdNsspOGCQcv8taBtBrIqy/QobXFslOG1H0CM32+9kJUQARR
7zefcGL4vFElWi5lQIxA4x6Hvacf6FA4p3ZtcZr2QgDxG08loxYuEkCZ7YxfI7bs
Ry0IeEV0A+MsYvkq4ynySHncRxAokB2QXABOARBUmHPEStnxn+YwUAgjGsk3uaW8
Psk93Jw3N3bsFEo0Nb8f500k8CSDYQhPW1TGYrxY4VphWUG22RoKdm3njWMVFvbm
qryKe5ifc09lj9n9l6rBQJ5e8VmGFaodtE2+Y0PPjuz8aCpBSgCDZjU4IfEHgiUK
bE3HoO4jPv80xe+uVeQMbml+jhtdnQccru8e/K7y3nR6PQM2FSmtvwjedzbLVfnW
jeI57hv24ANiXkRROVN9
=bHTb
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CF27A000-1187-469F-AD2C-88D2BDFF797F>