Date: Wed, 29 Aug 2018 13:52:32 -0400 From: Allan Jude <allanjude@freebsd.org> To: freebsd-current@freebsd.org Subject: Re: old top and new -current: missing arcstat sysctl Message-ID: <5531a2c9-dde5-acef-4199-040973535585@freebsd.org> In-Reply-To: <20180829151857.GA2709@raichu> References: <20180828084015.Horde.JUeG828X_SDlJjeJdfmH7pV@webmail.leidinger.net> <d7834f4e-f1ca-c02a-6fe1-472b8737058c@freebsd.org> <20180828144842.GA29917@raichu> <20180829074431.Horde.NYx7i7jvhNMNuTj-hSYfzSk@webmail.leidinger.net> <20180829151857.GA2709@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ySSpJMMGu9uCcHfONjGz7ORssi6jQopT0 Content-Type: multipart/mixed; boundary="dwfguC416gtKqkIlDIvPctq0WfXKqSULs"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: freebsd-current@freebsd.org Message-ID: <5531a2c9-dde5-acef-4199-040973535585@freebsd.org> Subject: Re: old top and new -current: missing arcstat sysctl References: <20180828084015.Horde.JUeG828X_SDlJjeJdfmH7pV@webmail.leidinger.net> <d7834f4e-f1ca-c02a-6fe1-472b8737058c@freebsd.org> <20180828144842.GA29917@raichu> <20180829074431.Horde.NYx7i7jvhNMNuTj-hSYfzSk@webmail.leidinger.net> <20180829151857.GA2709@raichu> In-Reply-To: <20180829151857.GA2709@raichu> --dwfguC416gtKqkIlDIvPctq0WfXKqSULs Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-08-29 11:18, Mark Johnston wrote: > On Wed, Aug 29, 2018 at 07:44:31AM +0200, Alexander Leidinger wrote: >> >> Quoting Mark Johnston <markj@freebsd.org> (from Tue, 28 Aug 2018 =20 >> 10:48:42 -0400): >> >>> On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: >>>> On 2018-08-28 02:40, Alexander Leidinger wrote: >>>>> Hi, >>>>> >>>>> top reports missing sysctl kstat.zfs.misc.arcstats.other_size for >>>>> 12.0-alpha3 with a top from an old-ish -current. >>>>> >>>>> Is/will this be handled via a compat-11 sysctl (my kernel is withou= t >>>>> compat-xx), or did this slip through? >> >>>> That is not something that a compat-xx package can handle. >>> >>> s/package/kernel option/? >> >> Sorry, the COMPAT_FREEBSDx kernel options was what I had in mind when = =20 >> I wrote this. >> >>>> That arcstat was broken up into 3 individual stats, which the >>>> 12.0-alpha3 version of top will sum together for you. >>>> >>>> I don't think we've had compat shims like this for previous versions= of >>>> top, I recall having similar issues when the 'laundry' counter was >>>> introduced. >>> >>> IIRC that would have been the inverted case of running a newer top(1)= >>> with an older kernel lacking the v_laundry_pages sysctl. In general = I'd >>> expect us to support running an older top(1) with newer kernels if we= >>> don't have to bend over backwards to provide compatibility. >> >> If the new top is summing the 3 up anyway, it sounds like we could =20 >> provide the old one as backwards compatibility, even if it is =20 >> redundant. I rather have an redundant counter and an old top working = >> (in the generic case of what we promise to our users; in this specific= =20 >> case for me I just need to get around to update the jails on the =20 >> corresponding systems), than bailing out without displaying anything. >=20 > I'm inclined to agree, especially since this (running older top(1)s) ha= s > come up before when I removed some VM sysctls: > https://reviews.freebsd.org/D16943 > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.o= rg" >=20 I misunderstood previously (COMPAT_FREEBSDxx vs the compat-xx package). I am in agreement with Mark about fixing this for 12.0 --=20 Allan Jude --dwfguC416gtKqkIlDIvPctq0WfXKqSULs-- --ySSpJMMGu9uCcHfONjGz7ORssi6jQopT0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJbht1jAAoJEBmVNT4SmAt+LWgP/jRF3wDHZAzSaXOOgrXY87zI btTUagETWGEZMD6tqNbH+k+1gW+02fonGMMvoN86vPHWZDCgCB0J0nxndGuyFyoT ZfzuOYSG9qr146fGOlyVTD+AaIZBX1aj7BlfeqfzhtOZjHz5pc0r4xn8SfnxW+Z4 1sKc2yFNO4Vx50KCxHLyQzvciByzne9OGozEiA6bwY/YLSPYHQojlkCvMxSQgwwE 0XdLC7Oi4OqlEord4xhD92G6EqoJPlZ1x7iSz+lzZHxLuT0HdKd0aUGVfI6Tfc9T Pat8/Ub2xCWIbKBPNCFSbzAN4hsnxgaYLlH+ItbFnyRml5Nchu+lyiuWb1Yexi2X /zCkvV66e6yHUbMpwGjgn7FV/oeNIvbQArjE9Le9FFHLNsPZ0domblHlCBWCCLKC RQ974qZ9eEsJKCbQxLfwD/PSCEI/52+CnRulMtYuHc/obze31zrxbd7tRU0i+um0 0J8ZAIXJaknlklNPLKxe+UIw3rhssRs3XkKQDqhr8YIpiWCG6tV5xRY4Sju6S5E6 dWSs7YyE2ORPJJPBU6D4V91HTSO0ioAEiO0k6W4bzvbtxP5J0BCigay0u78SiAUk ug1da9HFENSAAmKufYEsSh7PTTzZ4MpdvQjiBdGKoxGd+wWFH5lN6s59ruFP8uNq stB1AEn7o6BRygqqDmqa =PETL -----END PGP SIGNATURE----- --ySSpJMMGu9uCcHfONjGz7ORssi6jQopT0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5531a2c9-dde5-acef-4199-040973535585>