Date: Tue, 24 Jun 2014 15:25:45 -0700 From: Warner Losh <imp@bsdimp.com> To: Andrey Chernov <ache@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r267758 - head Message-ID: <F92859FB-7BA1-41AC-BE27-28E1360B61F1@bsdimp.com> In-Reply-To: <CF27A000-1187-469F-AD2C-88D2BDFF797F@bsdimp.com> References: <201406230054.s5N0suIA081734@svn.freebsd.org> <256E890F-9564-4741-A5D8-89543381CF2D@gmail.com> <53A9B494.3020709@freebsd.org> <DF5BDC7F-70A9-4707-BAFD-0530C6134F61@bsdimp.com> <CF27A000-1187-469F-AD2C-88D2BDFF797F@bsdimp.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Jun 24, 2014, at 2:38 PM, Warner Losh <imp@bsdimp.com> wrote:
>
> On Jun 24, 2014, at 2:26 PM, Warner Losh <imp@bsdimp.com> wrote:
>
>>
>> On Jun 24, 2014, at 10:25 AM, Andrey Chernov <ache@freebsd.org> wrote:
>>
>>> On 24.06.2014 20:07, Warner Losh wrote:
>>>>> Log:
>>>>> Change suggestion how to set MAKESYSPATH as broken incremental build
>>>>> workaround. Magic ".../share/mk" (search directories up to /)
>>>>> does not work for f.e. /usr/src/gnu/lib/libgcc because the path
>>>>> inside is starting from /usr/obj hierarchy and ends up in
>>>>> /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is.
>>>>> IMHO proper fixing of incremental build is needed urgently.
>>>>
>>>> I don’t understand how this is even possible. This change is wrong because it has a bogus path the doesn’t exist on all systems. I’m going to fix that.
>>>
>>> How it is possible:
>>> cd /usr/src/gnu/lib/libgcc
>>> make
>>
>> This does a recursive make, with pwd in /usr/obj…. That’s going to be utterly evil to fix…
>
> Actually, adding a simple cd ${.CURDIR} before the make fixes this… We need to do it in 3 places.
>
> # one could argue that we should just .include something to make unwind.h instead of this rube-goldberg reach over make…
> # and I’d agree with them…
This has been “fixed”…
that was a fun example… I have to go from “fixed” to actually fixed now…
Warner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJTqfrpAAoJEGwc0Sh9sBEANy0P/3zADp5+22OnaVfYmIkDmIZS
9cXAlsjINSk6uvVxmKBpWwtRcjdzk7gtMLV1TewO5/slvagpiCjzm6TiK/UNwLkt
kkjNNuCd6x4TPf48S6sYLa2/g7xjVw/CFxuzGKOXZ0OrK4nw/ipLUFrM1oFbzuno
v6JyRBwlajfr51NPBmJpyd5/MAQ+TRpWWAjRqtAjtEaWz3hL0bJ9B1ctqueuy3zS
Hu47fQMiaXwsBEkQnEK5LHm4QzK3JD/bu9hm+AQveuyJ5jh6ImCVmdS+d8jIhlWZ
5Jw3/j5HksQRR29AqbuVVk8uVSmGc+zadQSoJLBzcrDLVKKO/NATGa9dzfQt6wH6
jbJDHnG0hGoepmLEBK7Ff8QEKaVt1nWodlxFVcHDK5XbM0j7n1KmOHN652Vgb3kX
WawN9QieLE1HK9UfJB4yUM09zIDnbg7u6qN5bXqU9+buwfQMlpv7wexEWOX5zfcc
F4fXOKIHGfINPEq66WfFl5DfZOtRW7mLtV7q3izSIsjya8D0yTGfCF43EebIJ6dg
NnnUzhicydMDqXZuytCT13oHDSD/zMmtgziPjsQewoNxB4L88ok9qYzC0B+Bftfj
AfCmLue6+ob1di3Ky6IR2hFhoLmVjPr2Xj1quTUm0C5nrVXBnERn+Dxp8+7F0Kc1
K/9JBDUwhrAqM0hvvgHY
=GvjV
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F92859FB-7BA1-41AC-BE27-28E1360B61F1>