Date: Sun, 31 Dec 2017 14:22:35 -0800 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: Michael Butler <imb@protected-networks.net> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: SVN r327444 breaks current build Message-ID: <20171231222235.GA62313@bluezbox.com> In-Reply-To: <0b8f0e34-7a39-fd59-7f66-b55f1af0e920@protected-networks.net> References: <0b8f0e34-7a39-fd59-7f66-b55f1af0e920@protected-networks.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Butler (imb@protected-networks.net) wrote:
> Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vt_font_default.o
> --- vt_termcolors.o ---
> /usr/src/sys/dev/vt/colors/vt_termcolors.c:158:55: error: too many
> arguments to function call, expected 4, have 5
> if (vt_parse_rgb_triplet(rgb, strlen(rgb), &r,
> &g, &b) == 0) {
> ~~~~~~~~~~~~~~~~~~~~
> ^~
> /usr/src/sys/dev/vt/colors/vt_termcolors.c:77:1: note:
> 'vt_parse_rgb_triplet' declared here
> static int
> ^
> 1 error generated.
> *** [vt_termcolors.o] Error code 1
>
> <sigh> .. second time today a commit wasn't tested before commit :-(
>
> imb
Should be fixed in r327449. It was a sloppy job, I was making iterative
improvements to the original patch following review feedback and used
out-of-tree testcases for actual testing. I appologize for the breakage.
--
gonzo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171231222235.GA62313>