Date: Tue, 26 Oct 2010 19:58:05 +0200 From: Attilio Rao <attilio@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214380 - head/sys/x86/x86 Message-ID: <AANLkTik2db9MchJ5eJd3x9ZS_j-_VN9KZ-30ZXu%2B_BHL@mail.gmail.com> In-Reply-To: <4CC70BF9.30004@FreeBSD.org> References: <201010261616.o9QGGFgX053089@svn.freebsd.org> <4CC70BF9.30004@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/10/26 Dimitry Andric <dim@freebsd.org>:
> On 2010-10-26 18:16, Attilio Rao wrote:
>>
>> =C2=A0 Remove usage of PRI* macro for style compliancy.
>
> ...
>>
>> - =C2=A0 =C2=A0 =C2=A0 printf(" =C2=A0chunk %d: %"PRIu64"MB (%"PRIu64" p=
ages)", seqnr,
>> PG2MB(pgs),
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pgs);
>> + =C2=A0 =C2=A0 =C2=A0 printf(" =C2=A0chunk %d: %jdMB (%jd pages)", seqn=
r,
>> (uintmax_t)PG2MB(pgs),
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uintmax_t)pgs);
>
> If you cast to uintmax_t, you should use %ju instead. :) =C2=A0Otherwise,
> cast to intmax_t, e.g. if the PG2MB macro results in a signed value.
This bug was already existing with the old version, but yes, you and
Bruce are obviously right.
Thanks,
Attilio
--=20
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTik2db9MchJ5eJd3x9ZS_j-_VN9KZ-30ZXu%2B_BHL>