Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Oct 2014 15:30:02 +0000
From:      Steven Hartland <killing@multiplay.co.uk>
To:        freebsd-fs@freebsd.org
Subject:   Re: panic: detach with active requests on 10.1-RC3
Message-ID:  <544D137A.7010006@multiplay.co.uk>
In-Reply-To: <544CC4D4.7040203@FreeBSD.org>
References:  <544A538F.6060202@FreeBSD.org> <544BBB85.2020909@madpilot.net> <544BC990.4030700@madpilot.net> <544CC4D4.7040203@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------080209070109080503070307
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit


On 26/10/2014 09:54, Guido Falsi wrote:
> On 10/25/14 18:02, Guido Falsi wrote:
>> On 10/25/14 17:02, Guido Falsi wrote:
>>> On 10/24/14 15:26, Guido Falsi wrote:
>>>> Hi,
>>>>
>>>> I'm making some experiments with 10.1-RC3 on alix boards as hardware
>>>> using NanoBSD.
>>>>
>>>> By mounting and umounting UFS filesystems I have seen umount constantly
>>>> hanging hard in a deadlock. I have tested on two boards with two
>>>> distinct compactflash disks with same results. This was not happening
>>>> with 10.0-RELEASE.
>>>>
>>>> I have build a 10.1-RC3 kernel with full debugging and caused the
>>>> problem to happen, I got this:
>>>>
>>>> root@qtest:~ [0]# umount /cfg
>>>> panic: detach with active requests
>>>> KDB: stack backtrace:
> [...]
>> I must admit I am out of ideas.
>>
> I bisected commits and finally found out this happens starting with
> r268815, which MFCed r268205.
>
> It is related to trim support, in fact disabling trim on the filesystm
> "fixes" it.
>
> I filed bug #194606 on bugzilla [1] to further track this issue, if
> anyone is interested.
>
> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194606
Nice work Guido, can you try the attached patch and see if that fixes it 
please?

     Regards
     Steve


--------------080209070109080503070307
Content-Type: text/plain; charset=windows-1252;
 name="cf_erase.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="cf_erase.patch"

Index: sys/cam/ata/ata_da.c
===================================================================
--- sys/cam/ata/ata_da.c	(revision 273157)
+++ sys/cam/ata/ata_da.c	(working copy)
@@ -1470,6 +1470,8 @@ ada_cfaerase(struct ada_softc *softc, struct bio *
 	uint64_t lba = bp->bio_pblkno;
 	uint16_t count = bp->bio_bcount / softc->params.secsize;
 
+	bioq_remove(&softc->trim_queue, bp);
+
 	cam_fill_ataio(ataio,
 	    ada_retry_count,
 	    adadone,

--------------080209070109080503070307--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?544D137A.7010006>