Date: Fri, 17 May 2002 09:08:11 +0100 From: Ceri Davies <setantae@submonkey.net> To: Chris Pepper <pepper@reppep.com> Cc: Giorgos Keramidas <keramida@ceid.upatras.gr>, FreeBSD-doc@FreeBSD.org Subject: Re: [PATCH] <http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/cvs. operations.html> Message-ID: <20020517080811.GD5839@submonkey.net> In-Reply-To: <p05111906b909ee915174@[64.81.19.109]> References: <p05111901b908d6f0c7e5@[64.81.19.109]> <20020516164330.GA96701@hades.hell.gr> <20020516131122.516afea5.trhodes@FreeBSD.org> <p05111906b909ee915174@[64.81.19.109]>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 16, 2002 at 11:39:39PM -0400, Chris Pepper wrote: > At 1:11 PM -0400 2002/05/16, Tom Rhodes wrote: > >On Thu, 16 May 2002 19:43:30 +0300 > >Giorgos Keramidas <keramida@ceid.upatras.gr> wrote: > > > >> On 2002-05-15 23:29, Chris Pepper <pepper@reppep.com> wrote: > >> > >> You don't really need the whitespace change (moving 'or' at the > >> beginning of the last paragraph line). > >> > >> You might want to make `this' mode explicit, with something like: > >> > >> If you checked out a ``point in time'', then > >> <application>cvs</application> will do nothing, unless ... > >> > >> What do you think? > > Actually, the real change was addition of 'this' and a comma; > or was on one of the touched lines, so I reflowed it. I wouldn't > submit a patch just to fix wrapping. I think it's clear with my patch. Chris, Problem is that committing whitespace and textual changes together causes extra work for the translation guys (and Giorgos would know, as he's one of them), so patches containing both changes can't be used. Whoever commits changes will normally follow up with a whitespace commit to fix linewrap if it's necessary, so if you could avoid making whitespace changes then it's easier for us to commit as we don't have to change it back. We don't expect you to provide a whitespace only patch as well; we get to do that ourselves(!). I know this is sometimes really hard to do, but no matter how stupid the file looks once you've made your changes, please don't wrap. Thanks, Ceri -- get the cool shoe shine To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020517080811.GD5839>