Date: Tue, 20 Dec 2011 01:21:59 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Doug Barton <dougb@freebsd.org>, Max Khon <fjoe@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, =?ISO-8859-1?B?R+Fib3IgS/Z2ZXNk4W4=?= <gabor@t-hosting.hu>, svn-src-head@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r228143 - in head: . share/mk tools/build/options Message-ID: <CAGH67wTb=wkzjn-6rJK-43Pa25=koF-OAi0Sa%2BHwHW0jMq0x4Q@mail.gmail.com> In-Reply-To: <20111220171740.X1005@besplex.bde.org> References: <201111291946.pATJkHMs064094@svn.freebsd.org> <4ED544E1.3050307@t-hosting.hu> <4ED545A9.8000304@FreeBSD.org> <CAGH67wSn-kGhtW-qVwwEVvmmu076ncAqMXx=42PnWwb3a4cCbg@mail.gmail.com> <0CAA5754-4FAC-4B87-92B7-439B109473C0@bsdimp.com> <20111220171740.X1005@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 19, 2011 at 10:20 PM, Bruce Evans <brde@optusnet.com.au> wrote:
> On Mon, 19 Dec 2011, Warner Losh wrote:
>
>> On Nov 29, 2011, at 1:53 PM, Garrett Cooper wrote:
>>
>>> 2011/11/29 Doug Barton <dougb@freebsd.org>:
>>>>
>>>> On 11/29/2011 12:47, G=E1bor K=F6vesd=E1n wrote:
>>>>>
>>>>> On 2011.11.29. 20:46, Max Khon wrote:
>>>>>>
>>>>>> Log:
>>>>>> =A0 Turn off profiled libs build by default.
>>>>>> =A0 Can be enabled back using WITH_PROFILE=3Dyes in /etc/src.conf
>>>>>
>>>>> I think it was useful. Profiling is useful for developing any piece o=
f
>>>>> software that builds on libc or other common libs, even for software
>>>>> that is not directly related to FreeBSD. I think it should be reverte=
d.
>>>>
>>>>
>>>> Since we ask users to read -current, it would be useful if our
>>>> developers did too. :)
>>>>
>>>> As Max pointed out in his message about this, the profiled libs are on=
ly
>>>> really useful to a tiny percentage of developers. If you need them,
>>>> twist the knob. Building them should be off by default.
>>>
>>>
>>> +1. The needs of the many outweigh the needs of the few. As suggested
>>> elsewhere, I think it would also be a good idea to enable it in
>>> tinderbox builds.
>>
>>
>> -1. =A0The needs of the many? =A0Please. =A0Let's break a useful feature=
because
>> some people don't understand it and are impatient? =A0That's lame.
>
> Don't be silly. =A0Building profiled libraries takes as much as 1 minute.
> Many would not want to wait that long (if they noticed how long it takes)=
.
> This is not 1994 when building of profiling libraries was left in because
> it only took an extra hour or or so.
The assumption (that isn't clearly stated) is that I am building
things on suped up x86 hardware, not arm CPUs, Intel Atoms, etc. On
those platforms building superfluous things still do matter (in
particular because cross-building some things still isn't doable 100%
of the time, but also because flash, some platter media, etc is slow).
But I suppose I digress...
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTb=wkzjn-6rJK-43Pa25=koF-OAi0Sa%2BHwHW0jMq0x4Q>