Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Dec 2025 11:47:28 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: 1aea5b0ba76a - main - nvme: make the interface standard file
Message-ID:  <CANCZdfq1hHzsfq0L87b58T9w32yRAbYaM=GRf2tUjV-4hTN-2w@mail.gmail.com>
In-Reply-To: <694ad6f7.3129d.4b8eaff6@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
Thanks Gleb! This is the right fix.

Warner

On Tue, Dec 23, 2025 at 10:52 AM Gleb Smirnoff <glebius@freebsd.org> wrote:

> The branch main has been updated by glebius:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=1aea5b0ba76a30cc9753fbc860c0f35a980b756b
>
> commit 1aea5b0ba76a30cc9753fbc860c0f35a980b756b
> Author:     Gleb Smirnoff <glebius@FreeBSD.org>
> AuthorDate: 2025-12-23 17:51:25 +0000
> Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
> CommitDate: 2025-12-23 17:51:25 +0000
>
>     nvme: make the interface standard file
>
>     This makes nvme.ko and nvd.ko loadable.
>
>     Fixes:  aed44717a1606e4c5c79f7c8831de49cba64d7e6
> ---
>  sys/conf/files | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/conf/files b/sys/conf/files
> index d41e3ccc23be..474f337e569a 100644
> --- a/sys/conf/files
> +++ b/sys/conf/files
> @@ -2582,7 +2582,7 @@ dev/nvme/nvme_sim.c               optional nvme scbus
>  dev/nvme/nvme_sysctl.c         optional nvme
>  dev/nvme/nvme_test.c           optional nvme
>  dev/nvme/nvme_util.c           optional nvme | scbus
> -dev/nvme/nvme_if.m             optional nvme
> +dev/nvme/nvme_if.m             standard
>  dev/nvmem/nvmem.c              optional nvmem fdt
>  dev/nvmem/nvmem_if.m           optional nvmem
>  dev/nvmf/controller/ctl_frontend_nvmf.c                optional nvmft
>
>

[-- Attachment #2 --]
<div dir="ltr">Thanks Gleb! This is the right fix.<div><br></div><div>Warner</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Dec 23, 2025 at 10:52 AM Gleb Smirnoff &lt;<a href="mailto:glebius@freebsd.org">glebius@freebsd.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by glebius:<br>
<br>
URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=1aea5b0ba76a30cc9753fbc860c0f35a980b756b" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=1aea5b0ba76a30cc9753fbc860c0f35a980b756b</a><br>;
<br>
commit 1aea5b0ba76a30cc9753fbc860c0f35a980b756b<br>
Author:     Gleb Smirnoff &lt;glebius@FreeBSD.org&gt;<br>
AuthorDate: 2025-12-23 17:51:25 +0000<br>
Commit:     Gleb Smirnoff &lt;glebius@FreeBSD.org&gt;<br>
CommitDate: 2025-12-23 17:51:25 +0000<br>
<br>
    nvme: make the interface standard file<br>
<br>
    This makes nvme.ko and nvd.ko loadable.<br>
<br>
    Fixes:  aed44717a1606e4c5c79f7c8831de49cba64d7e6<br>
---<br>
 sys/conf/files | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/sys/conf/files b/sys/conf/files<br>
index d41e3ccc23be..474f337e569a 100644<br>
--- a/sys/conf/files<br>
+++ b/sys/conf/files<br>
@@ -2582,7 +2582,7 @@ dev/nvme/nvme_sim.c               optional nvme scbus<br>
 dev/nvme/nvme_sysctl.c         optional nvme<br>
 dev/nvme/nvme_test.c           optional nvme<br>
 dev/nvme/nvme_util.c           optional nvme | scbus<br>
-dev/nvme/nvme_if.m             optional nvme<br>
+dev/nvme/nvme_if.m             standard<br>
 dev/nvmem/nvmem.c              optional nvmem fdt<br>
 dev/nvmem/nvmem_if.m           optional nvmem<br>
 dev/nvmf/controller/ctl_frontend_nvmf.c                optional nvmft<br>
<br>
</blockquote></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq1hHzsfq0L87b58T9w32yRAbYaM=GRf2tUjV-4hTN-2w>