Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 22 Sep 2015 22:38:48 +0200
From:      Dirk Engling <erdgeist@erdgeist.org>
To:        Iain Hibbert <plunky@ogmig.net>
Cc:        "freebsd-bluetooth@freebsd.org" <freebsd-bluetooth@freebsd.org>
Subject:   Re: Apple Magic Mouse
Message-ID:  <5601BC58.9060200@erdgeist.org>
In-Reply-To: <alpine.NEB.2.11.1509222049120.329@galant.ogmig.net>
References:  <1437909200.57929.3.camel@yandex.com> <alpine.NEB.2.11.1508092034290.5638@galant.ogmig.net> <55F4362A.4050203@erdgeist.org> <CAFPOs6p%2BEZDctPodY6DBbnhfZQFz%2Bo0uKSRvvqQBcM1QL3ACXw@mail.gmail.com> <55F60ED8.8080203@erdgeist.org> <alpine.NEB.2.11.1509141802300.690@galant.ogmig.net> <55F78EB8.8060408@erdgeist.org> <55FCDBB6.6090004@erdgeist.org> <55FF08C5.1020509@erdgeist.org> <alpine.NEB.2.11.1509222049120.329@galant.ogmig.net>
index | next in thread | previous in thread | raw e-mail 

On 22.09.15 22:03, Iain Hibbert wrote:

> in the rest of SDP code, these are styled SDP_ATTR_* is there a reason to 
> be different?

No, when I first wrote that code for bthidd, there was no other SDP
related code to steal from, so I never noticed there were naming
conventions. Going to fix that in phabricator.

> it is not required to credit the source of the information used to write 
> the handler for this device, but it is good practice to do so :)

Frankly, I never thought about how code from now on gets it's proper
attribution. Apple's proprietary report format now is only implicitly
documented in code and I normally hate putting arbitrary integer offsets
in code.

But on the other hand I have the feeling that already there is too much
non-generic code that does not even adhere to HID in a generic HID
driver and this is without a magic track pad handler. That left me
wondering if all of this should move to another object or maybe even out
of the generic bthid driver.

So I wonder how much documentation or reference to documentation is
adequate. Also, how does one properly link to linux or netbsd driver source?

  erdgeist
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5601BC58.9060200>