Date: Tue, 13 Feb 2007 22:30:22 +0100 From: Danny Pansters <danny@ricin.com> To: freebsd-ports@freebsd.org Cc: Yuri Pankov <y.pankov@irbis.net.ru> Subject: Re: multimedia/kbtv: broken saa kmod? Message-ID: <200702132230.22373.danny@ricin.com> In-Reply-To: <20070213030913.GA23018@darklight.abyss.local> References: <47998907@srv.sem.ipt.ru> <200702122145.19885.danny@ricin.com> <20070213030913.GA23018@darklight.abyss.local>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 13 February 2007 04:09, Yuri Pankov wrote:
<snip>
> Hi,
>
> I've attached a patch allowing saa kmod to compile cleanly on amd64 with
> WERROR defined.
>
> I don't use kbtv but am interested in saa713x driver, so improvements to
> make it work in SECAM are welcome. Just setting SECAM video standard to get
> colour picture seems pretty easy, given the code in
> saa/saa/support/set_videoopt.c. Diff adding SECAM option to it is also
> attached.
Thanks. Should be in the driver really, so that GETVIDEOSTD provides it.
>
> Another question - is anyone successfully running this driver on -CURRENT?
> I'm wondering cause of the following change by imp@ to iicbus.c, denying
> attach of generic iic device:
>
> ===================================================================
> RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/dev/iicbus/iicbus.c,v
> retrieving revision 1.21
> retrieving revision 1.22
> diff -u -p -r1.21 -r1.22
>
> <snip>
>
> @@ -139,51 +139,52 @@ iicbus_attach(device_t dev)
> printf("\n");
> #endif
>
> - /* attach any known device */
> device_add_child(dev, "ic", -1);
> - device_add_child(dev, "iic", -1);
> device_add_child(dev, "iicsmb", -1);
Outch. I would think yes, this would be a problem (I don't run 7-current yet).
BTW, I did notice that iic(4) behaves different than its manpage says. At
least with the (mk3) tuner programming I found that write command doesn't
automagically takes care of start/stop conditions. I really must START first
(and write first cmd) then after that can use write. The Philips tuner
documentation also specifically says first start then optionally write/read
then stop. I see the same in Rohit's tuning code (plus some bus resets). In
the kbtv saa module I only reset the bus at tuner/IF init, not while changing
channels.
Sometimes it loses its way and tunes to 0 MHz but fortunately it can then be
correctly tuned again. I recall Rohit's ftvv app having a button "restart IF"
or something alike the meaning of which I only understood much later :)
Dan
> -
> +#if 0
> + /* attach any known device */
> + device_add_child(dev, "iic", -1);
> +#endif
> bus_generic_attach(dev);
> -
> return (0);
> }
>
> <snip>
>
>
> HTH,
> Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702132230.22373.danny>