Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Jun 2017 18:10:04 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r319545 - head/usr.sbin/newsyslog/tests
Message-ID:  <201706031810.v53IA47S049947@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Sat Jun  3 18:10:04 2017
New Revision: 319545
URL: https://svnweb.freebsd.org/changeset/base/319545

Log:
  Don't execute the TODO cases in a subshell
  
  This messes up the testcase counter, as seen in bug 219756.
  
  PR:		212160, 219756
  Sponsored by:	Dell EMC Isilon

Modified:
  head/usr.sbin/newsyslog/tests/legacy_test.sh

Modified: head/usr.sbin/newsyslog/tests/legacy_test.sh
==============================================================================
--- head/usr.sbin/newsyslog/tests/legacy_test.sh	Sat Jun  3 17:59:10 2017	(r319544)
+++ head/usr.sbin/newsyslog/tests/legacy_test.sh	Sat Jun  3 18:10:04 2017	(r319545)
@@ -380,7 +380,6 @@ tests_time_rotate() {
 
 	sleep 1.1
 
-	(
 	TODO="rotate time 2-4 fail today; bug 212160"
 
 	begin "rotate time 2 ${name_postfix}"
@@ -404,7 +403,7 @@ tests_time_rotate() {
 	ckfe ${LOGFNAME}
 	chkfcnt 3 ${dir}${LOGFNAME}.*${ext}
 	end
-	)
+	unset TODO
 
 	begin "noaction ${name_postfix}"
 	ofiles=`ls -1 ${dir}${LOGFNAME}.*${ext} | tr -d '\n'`



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201706031810.v53IA47S049947>