Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Jun 2022 13:43:38 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        "Bjoern A. Zeeb" <bz@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 9fd0d9b16e93 - main - ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP kernel configurations.
Message-ID:  <eba2a833-d7b5-7ba1-8afb-b05283002983@selasky.org>
In-Reply-To: <alpine.BSF.2.00.2206112003291.68830@ai.fobar.qr>
References:  <202206111932.25BJW6w6040018@gitrepo.freebsd.org> <alpine.BSF.2.00.2206112003291.68830@ai.fobar.qr>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/11/22 22:04, Bjoern A. Zeeb wrote:
> On Sat, 11 Jun 2022, Hans Petter Selasky wrote:
> 
>> The branch main has been updated by hselasky:
>>
>> URL: 
>> https://cgit.FreeBSD.org/src/commit/?id=9fd0d9b16e93ff2a3bd375a98763dca0150dcee0 
>>
>>
>> commit 9fd0d9b16e93ff2a3bd375a98763dca0150dcee0
>> Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
>> AuthorDate: 2022-06-11 19:29:42 +0000
>> Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
>> CommitDate: 2022-06-11 19:31:28 +0000
>>
>>    ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP 
>> kernel configurations.
>>
>>    Kernel TLS depends on INET or INET6 being enabled.
> 
> That is only a short-term solution hiding the actual problem and will
> now propably never be fixed again like these device drivers which were
> on that list ofr ages...

+1

There is a plan to replace config at some point. I believe this is a 
limitation of sys/conf/files, that it doesn't provide a good way to 
handle conflicts. There are many ifdef KERN_TLS, so just skipping one 
file for building won't help.

https://hackmd.io/w1Tf8mmVQVuZok7-LNEhgw

--HPS

> 
> 
>>    Reported by:    bz@
>>    MFC after:      1 week
>>    Sponsored by:   NVIDIA Networking
>> ---
>> sys/amd64/conf/LINT-NOIP | 1 +
>> sys/i386/conf/LINT-NOIP  | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/sys/amd64/conf/LINT-NOIP b/sys/amd64/conf/LINT-NOIP
>> index e951a0878b29..0d4ec1e8c1ac 100644
>> --- a/sys/amd64/conf/LINT-NOIP
>> +++ b/sys/amd64/conf/LINT-NOIP
>> @@ -6,6 +6,7 @@ makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT="
>> makeoptions MKMODULESENV+="WITHOUT_INET6_SUPPORT="
>> nooptions INET
>> nooptions INET6
>> +nooptions KERN_TLS
>> nodevice age
>> nodevice alc
>> nodevice ale
>> diff --git a/sys/i386/conf/LINT-NOIP b/sys/i386/conf/LINT-NOIP
>> index 2f21766eb69e..1c91dae98baa 100644
>> --- a/sys/i386/conf/LINT-NOIP
>> +++ b/sys/i386/conf/LINT-NOIP
>> @@ -5,6 +5,7 @@ makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT="
>> makeoptions MKMODULESENV+="WITHOUT_INET6_SUPPORT="
>> nooptions INET
>> nooptions INET6
>> +nooptions KERN_TLS
>> nodevice age
>> nodevice alc
>> nodevice ale
>>
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eba2a833-d7b5-7ba1-8afb-b05283002983>