Date: Sun, 27 May 2007 17:14:34 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netncp ncp_conn.c Message-ID: <200705271714.l4RHEYOr018283@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2007-05-27 17:14:34 UTC FreeBSD src repository Modified files: sys/netncp ncp_conn.c Log: In ncp_conn_alloc(), a new credential pointer, 'owner', is set up to point at the credential to be used by the connection. However, the pointer's value was ignored when actually setting hcp->nc_owner. (1) Do set nc_owner to the owner pointer value so that the credential is not discarded after being carefully configured. (2) In the case where we create a new credential with modified uid, copy the existing credential to initialize non-uid fields to existing values, which will lead to a fully initialized MAC label, groups, etc. Found with: Coverity Prevent(tm) CID: 2226 Revision Changes Path 1.30 +4 -3 src/sys/netncp/ncp_conn.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705271714.l4RHEYOr018283>