Date: Tue, 02 Apr 2002 14:28:08 -0800 From: bmah@FreeBSD.org To: obrien@FreeBSD.org Cc: "Bruce A. Mah" <bmah@FreeBSD.org>, Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 8929 for review Message-ID: <200204022228.g32MS8VB039655@intruder.bmah.org> In-Reply-To: <20020402140528.A48987@dragon.nuxi.com> References: <200204022153.g32LrnQ29689@freefall.freebsd.org> <20020402140528.A48987@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
If memory serves me right, "David O'Brien" wrote: > On Tue, Apr 02, 2002 at 01:53:49PM -0800, Bruce A. Mah wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8929 > > > > Change 8929 by bmah@bmah_intruder on 2002/04/02 13:52:50 > > > > Don't make the assumption that source files are writable. > > The FDP infrastructure has a few constructs of the form > > "cp foo bar; cat baz >> bar". This breaks if foo isn't > > writable (as is frequently the case in P4 work directory). > > > > I'm not sure if this change should be made in CVS or not, > > and if so, if this is exactly the right change. In the meantime, > > we've at least unbroken doc builds out of P4 work areas. > > It should, otherwise we break assumptions of read-only sources. The problem here was not that we actually tried to modify any of the source files. In that sense, the old infrastructure always worked with read-only sources. The difficulty was the assumption that if you made a copy of a source file, the permission bits on the copy would allow you to write/append to it. Files in a P4 work area can violate this assumption because they have read-only filesystem permissions until you do a "p4 edit". In any case, I want to ponder this a bit more before deciding whether this is the change we want to commit "for real" to CVS, or if we should do some variant of this. Thanks, Bruce. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-releng" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204022228.g32MS8VB039655>