Date: Mon, 22 Jan 2018 12:29:40 -0700 From: Warner Losh <imp@bsdimp.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: John Baldwin <jhb@freebsd.org>, Emmanuel Vadot <manu@bidouilliste.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <CANCZdfp6t6KrTkp=O7Z9crnAUZhFMr%2BW-92t9S480=OytJdpfg@mail.gmail.com> In-Reply-To: <89102.1516649067@critter.freebsd.dk> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <88258.1516630050@critter.freebsd.dk> <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> <52374125.OgxafgljNu@ralph.baldwin.cx> <89102.1516649067@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 22, 2018 at 12:24 PM, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: > -------- > In message <52374125.OgxafgljNu@ralph.baldwin.cx>, John Baldwin writes: > > >Create the corresponding device_t but device_disable() it when there > >is a disabled property. > > That also removes a couple of boilerplate lines from all FDT device > drivers. That would be useful, but the status bit is so much more than on/off. >A user can then use 'devctl enable <blah>' to enable > >it before (or even after) loading a device driver. > > That would work for me. > > I wonder if it would be too noisy if we allowed ->probe() to run > on disabled devices and reported something like: > > "foobar0: Matched disabled device <...>" > > (without calling ->attach()) > > That way you would know you loaded the right driver, rather > than have to guess. I suspect that would be too noisy. It would be better to just run probe, but then have newbus report it's disabled so we never go onto attach. Though, there's more fundamental issues at play since FDT is tricky and a lot more interrelated than other enumeration platforms. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp6t6KrTkp=O7Z9crnAUZhFMr%2BW-92t9S480=OytJdpfg>