Date: Wed, 16 Nov 2011 19:26:09 +0100 From: Robert Millan <rmh@freebsd.org> To: d@delphij.net Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers Message-ID: <CAOfDtXO5FcNv2=%2BLr4m-OVGpkL9Y703yGpQ%2B_fdKFpT_PaRa2g@mail.gmail.com> In-Reply-To: <4EC3FBD2.4070009@delphij.net> References: <CAOfDtXPX1Rv9T7%2B1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com> <4EC3FBD2.4070009@delphij.net>
index | next in thread | previous in thread | raw e-mail
2011/11/16 Xin LI <delphij@delphij.net>: > Just my $0.02 -- I think we should probably do it in a more > centralized place -- otherwise in case someone imported some new code, > they have to do the same defined(__FreeBSD__) || > defined(__FreeBSD_kernel__)? How about something like: #if defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) #define __FreeBSD_kernel__ #endif it can be placed at beginning of each header, then the rest becomes much simpler. Note this has the side-effect of defining __FreeBSD_kernel__ on FreeBSD, which I suspect some people won't be fond of. An alternative could be to come up with an ad-hoc macro that means "this system is either FreeBSD or uses the same kernel as FreeBSD" and define it where needed.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXO5FcNv2=%2BLr4m-OVGpkL9Y703yGpQ%2B_fdKFpT_PaRa2g>