Date: Wed, 30 Jul 2014 16:52:21 +0400 From: Eygene Ryabinkin <rea@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, marino@freebsd.org, William Grzybowski <wg@freebsd.org>, ports-committers@freebsd.org, Adam Weinberger <adamw@adamw.org> Subject: make makepatch and per-file diffs [WAS: Re: svn commit: r363361 - in head/editors/fte: . files] Message-ID: <KZS3hih2bcfVw91acbMzwi/jJJc@dHhGgwofm7uNfL6/X5%2BbGIkDUYs> In-Reply-To: <6270029E710D3C52B60B6224@atuin.in.mat.cc> References: <201407291646.s6TGkjHH090335@svn.freebsd.org> <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--XkdrZ7OMnakiJ6dL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote: > But, I think you're missing the point, who cares what the separator > is ? All it needs to do is work when I run make patch. Also, all > one needs to know is that to generate the patches, you run make > makepatch. Pardon me, but this is a short-term or port's user point of view. Port maintainers may (and should) also have some idea on what's the patch is about and to have not just single patch file for a single modified file, but have different hunks that are related to a single change to be grouped together in one file. That horribly eases the maintainership and its transfer to other persons (especially the latter). Currently 'make makepatch' takes us even behind CVS era where you had one diff for each commit and each file: it glues together all (possibly unrelated) changes in a single file to a single diff. Yes, there is an issue for patch ordering and 'make makepatch' tries to solve precisely that problem putting everything to per-file diffs. But it misses the whole point of having good quality patches inside files/ and does only poor-man work. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --XkdrZ7OMnakiJ6dL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlPY6oVfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PsGigD/T8haRbeVyRVIDPj+hu5vGcLh Ur+SA18eD9F0Q0QscwUA/0cj46wpDoRQIkzQFF8AV7Nb6VvrM2hT0xq+js88RMwJ =jpik -----END PGP SIGNATURE----- --XkdrZ7OMnakiJ6dL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?KZS3hih2bcfVw91acbMzwi/jJJc>