Date: Wed, 14 Apr 2004 09:03:19 -0600 From: Scott Long <scottl@freebsd.org> To: Brian Feldman <green@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c src/sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c ich.c t4dwave.c src/sys/dev/sound/pcm sound.h Message-ID: <407D52B7.80507@freebsd.org> In-Reply-To: <200404141457.i3EEvo7h069562@repoman.freebsd.org> References: <200404141457.i3EEvo7h069562@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Brian Feldman wrote: > green 2004/04/14 07:57:50 PDT > > FreeBSD src repository > > Modified files: > sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c > sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c > ich.c t4dwave.c > sys/dev/sound/pcm sound.h > Log: > The newpcm headers currently #define away INTR_MPSAFE and INTR_TYPE_AV > because they bogusly check for defined(INTR_MPSAFE) -- something which > never was a #define. Correct the definitions. > > This make INTR_TYPE_AV finally get used instead of the lower-priority > INTR_TYPE_TTY, so it's quite possible some improvement will be had > on sound driver performance. It would also make all the drivers > marked INTR_MPSAFE actually run without Giant (which does seem to > work for me), but: > INTR_MPSAFE HAS BEEN REMOVED FROM EVERY SOUND DRIVER! > It needs to be re-added on a case-by-case basis since there is no one > who will vouch for which sound drivers, if any, willy actually operate > correctly without Giant, since there hasn't been testing because of > this bug disabling INTR_MPSAFE. > Ha! you touched it last! Neener neener neener! Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?407D52B7.80507>