Date: Mon, 13 Jun 2022 08:32:51 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: "Bjoern A. Zeeb" <bz@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part Message-ID: <CANCZdfoqnsJKLtqrwpY35EMGKoQvEYnn158HQNBHEg1=X%2BKZZA@mail.gmail.com> In-Reply-To: <d514e0de-9b30-b5c8-2e2f-7e93a36747f7@FreeBSD.org> References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> <d514e0de-9b30-b5c8-2e2f-7e93a36747f7@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jun 13, 2022, 8:28 AM John Baldwin <jhb@freebsd.org> wrote: > On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote: > > The branch main has been updated by bz: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea > > > > commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea > > Author: Bjoern A. Zeeb <bz@FreeBSD.org> > > AuthorDate: 2022-06-12 18:35:58 +0000 > > Commit: Bjoern A. Zeeb <bz@FreeBSD.org> > > CommitDate: 2022-06-12 18:35:58 +0000 > > > > rtw88: split driver up into a core and pci part > > > > Split the driver up into two modules (if_rtw88_pci.ko and > rtw88_core.ko). > > This is in preparation for the hopefully eventually upcoming USB > support > > using the same driver core. > > > > Note: this changes the module name to load to if_rtw88_pci.ko > instead of > > if_rtw88.ko. If using devmatch(8) everything should stay the same > as > > the driver name (used for net.wlan.devices) stays rtw88. If using > > kld_list in rc.conf or loader.conf you will need to adjust the name. > > Update man page for this. > > > > MFC after: 3 days > > This sort of split in a .ko is kind of rare for drivers in the tree that > support > multiple bus attachments. Usually we just lump all the attachments into > the same > .ko. It's true that with the death of ISA, etc. we no longer have as many > drivers > with multiple bus attachments, but the norm has been to include them all > in a > single .ko. Is there a reason you can't follow the normal practice here? > Agreed. Furthermore, in the past when a couple of drivers did the we had issues and confusion. Please don't MFC until this discussion is done. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 13, 2022, 8:28 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote:<br> > The branch main has been updated by bz:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea</a><br>; > <br> > commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea<br> > Author: Bjoern A. Zeeb <bz@FreeBSD.org><br> > AuthorDate: 2022-06-12 18:35:58 +0000<br> > Commit: Bjoern A. Zeeb <bz@FreeBSD.org><br> > CommitDate: 2022-06-12 18:35:58 +0000<br> > <br> > rtw88: split driver up into a core and pci part<br> > <br> > Split the driver up into two modules (if_rtw88_pci.ko and rtw88_core.ko).<br> > This is in preparation for the hopefully eventually upcoming USB support<br> > using the same driver core.<br> > <br> > Note: this changes the module name to load to if_rtw88_pci.ko instead of<br> > if_rtw88.ko. If using devmatch(8) everything should stay the same as<br> > the driver name (used for net.wlan.devices) stays rtw88. If using<br> > kld_list in rc.conf or loader.conf you will need to adjust the name.<br> > Update man page for this.<br> > <br> > MFC after: 3 days<br> <br> This sort of split in a .ko is kind of rare for drivers in the tree that support<br> multiple bus attachments. Usually we just lump all the attachments into the same<br> .ko. It's true that with the death of ISA, etc. we no longer have as many drivers<br> with multiple bus attachments, but the norm has been to include them all in a<br> single .ko. Is there a reason you can't follow the normal practice here?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Agreed. Furthermore, in the past when a couple of drivers did the we had issues and confusion. Please don't MFC until this discussion is done. </div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoqnsJKLtqrwpY35EMGKoQvEYnn158HQNBHEg1=X%2BKZZA>