Date: Mon, 25 Mar 2002 00:10:36 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Bruce Evans <bde@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys bio.h conf.h disklabel.h diskslice.h event.h file.h filedesc.h libkern.h malloc.h mount.h msgbuf.h protosw.h socketvar.h sysent.h systm.h Message-ID: <20020325000318.S44582-100000@gamplex.bde.org> In-Reply-To: <20020323123015.A861@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 23 Mar 2002, David O'Brien wrote:
> On Sat, Mar 23, 2002 at 12:46:52AM -0800, Bruce Evans wrote:
> > Modified files:
> > sys/sys bio.h conf.h disklabel.h diskslice.h
> > event.h file.h filedesc.h libkern.h
> > malloc.h mount.h msgbuf.h protosw.h
> > socketvar.h sysent.h systm.h
> > Log:
> > Fixed some style bugs in the removal of __P(()). The main ones were
^^^^
> > not removing tabs before "__P((", and not outdenting continuation lines
> > to preserve non-KNF lining up of code with parentheses. Switch to KNF
> > formatting and/or rewrap the whole prototype in some cases.
^^^^
>
> According to style(9) you have not KNF'ed the prototypes.
> Applicable example:
>
> static char *function(int _arg, const char *_arg2, struct foo *_arg3,
> struct bar *_arg4);
I only claimed to fix some cases :-). I tried to changed the style to the
above only in cases where the function name was indented by 1 or 2 tabs
_and_ the removal of __P(()) caused a style regression.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020325000318.S44582-100000>