Date: Sun, 27 Mar 2016 23:33:02 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: toolchain@FreeBSD.org Subject: Re: CXXSTD=c++11 Message-ID: <222A6D82-ED88-4F93-869E-6615BFEE0441@FreeBSD.org> In-Reply-To: <56F475CB.8020107@FreeBSD.org> References: <56F46BE0.7080909@FreeBSD.org> <43ABA5F3-60E0-4A29-9698-B345A3DA0A8B@FreeBSD.org> <56F46E1B.4010605@FreeBSD.org> <56F46F67.2000807@FreeBSD.org> <7B77010A-B377-4B1A-835A-D48F59E5290D@FreeBSD.org> <DE6BC456-3949-4DEF-A8AC-3996680FA0EA@FreeBSD.org> <56F475CB.8020107@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_73059E3B-2345-46FE-86B3-1AF41FF703E7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=windows-1252 On 25 Mar 2016, at 00:18, Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > On 3/24/2016 4:16 PM, Dimitry Andric wrote: >> On 24 Mar 2016, at 23:54, Dimitry Andric <dim@FreeBSD.org> wrote: >>> >>> On 24 Mar 2016, at 23:51, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >> ... >>>> It fails without -std=c++11 (there's more discussion in that link and in >>>> PR 205453). >>> >>> Yeah, I also commented on PR 205453 in the past, but I still don't >>> understand where the external gcc gets its _Static_assert macro from. >>> Or whether it gets it at all. Maybe we should place a hack for this in >>> sys/cdefs.h? We shouldn't litter contrib code with #ifdef GCC_VERSION >>> blocks. >> >> Hm, hacking around in cdefs.h also doesn't really help, because gcc >> refuses to recognize either _Static_assert or static_assert when it's >> not in C++11 mode. Reading back https://reviews.freebsd.org/D1390, I >> see that I originally wanted to avoid building libcxxrt with -std=c++11. >> This was so you could even build it with gcc 4.2.1 from base. >> >> However, it really doesn't make much sense to do so, and upstream >> libcxxrt simply uses static_assert directly, and requires -std=c++11. I >> will update the libcxxrt build to do so, probably tomorrow. >> > > Sounds good. Done in r297299 [1]. I also imported libc++ r255683 [2], which should fix llvm-cov compilation with g++, in r297322 [3]. -Dimitry [1] https://svnweb.freebsd.org/changeset/base/297299 [2] http://reviews.llvm.org/rL255683 [3] https://svnweb.freebsd.org/changeset/base/297322 --Apple-Mail=_73059E3B-2345-46FE-86B3-1AF41FF703E7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.29 iEYEARECAAYFAlb4UY4ACgkQsF6jCi4glqOT8wCfRanHMTeKfjRRO/KxIhYIJ+Ij n/4AoIv7xInkqgdqdz+FMaOwgOqTz6zt =72Cv -----END PGP SIGNATURE----- --Apple-Mail=_73059E3B-2345-46FE-86B3-1AF41FF703E7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?222A6D82-ED88-4F93-869E-6615BFEE0441>