Date: Sat, 16 Jul 2011 15:16:20 +0400 From: Pan Tsu <inyaoo@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: current@freebsd.org Subject: Re: [PATCH] Export per-thread resource usage via sysctl Message-ID: <864o2mfpbv.fsf@gmail.com> References: <201107151343.40065.jhb@freebsd.org> <20110716093445.GA15357@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Best <arundel@freebsd.org> writes: > On Fri Jul 15 11, John Baldwin wrote: >> This change exports each individual thread's resource usage via sysctl when >> individual threads are requested via KERN_PROC_INC_THREAD. This generally >> works correctly with 'top -m io' after the previous change to revert top(1) >> back to using KERN_PROC_PROC when threads are not enabled. There is one issue >> in that top doesn't necessarily DTRT when disabling/enabling threads via 'H' >> at runtime while in io mode. I may do some further work to clean that up. >> However, for just top run it will now show per-thread stats instead of >> duplicating the per-process stats for each thread. > > i'm not sure, if i understand what the patch is supposed to do. however after > applying it, and recompiling/reinstalling the kernel, 'top -mio' displays the > same stats for each thread of a process. if i understood you correctly, each > thread should have individual stats. > > i'm running r224068 on amd64 and just reinstalled 'top'. anything i am missing? FWIW, I see different numbers for a few threads of firefox-bin with top-3.8b1. http://img233.imageshack.us/img233/1570/81482202.png Which is an improvement compared to how all threads showed same numbers before applying the patch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864o2mfpbv.fsf>