Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Nov 2010 22:27:02 -0200
From:      "Carlos A. M. dos Santos" <unixmania@gmail.com>
To:        Benjamin Close <Benjamin.Close@clearchain.com>
Cc:        svn-src-all@freebsd.org, bschmidt@freebsd.org
Subject:   Re: svn commit: r215563 - stable/8/sys/net80211
Message-ID:  <AANLkTikK7mbNkKUWUUBQKyTOaKWaPqNzforr3ZCZa6RS@mail.gmail.com>
In-Reply-To: <4CE9ADE2.1040905@clearchain.com>
References:  <201011201324.oAKDO5mB013288@svn.freebsd.org> <4CE9ADE2.1040905@clearchain.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sun, Nov 21, 2010 at 9:40 PM, Benjamin Close
<Benjamin.Close@clearchain.com> wrote:
>  Is this really the same thing?
> I believe the variable:number is a bitfield indicator not a member
> initialization.

Indeed it is, in a struct declaration, but that was was an
initialization (notice the equal sign before the brace). That syntax
is obsolete since GCC 2.5. Refer to

     http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Designated-Inits.html

> On 20/11/10 23:54, Bernhard Schmidt wrote:
>>
>> Author: bschmidt
>> Date: Sat Nov 20 13:24:05 2010
>> New Revision: 215563
>> URL: http://svn.freebsd.org/changeset/base/215563
>>
>> Log:
>>   MFC r209092:
>>   Remove GNU-style struct initialization.
>>
>>   Committed by:        ed
>>
>> Modified:
>>   stable/8/sys/net80211/ieee80211_rssadapt.c
>> Directory Properties:
>>   stable/8/sys/   (props changed)
>>   stable/8/sys/amd64/include/xen/   (props changed)
>>   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
>>   stable/8/sys/contrib/dev/acpica/   (props changed)
>>   stable/8/sys/contrib/pf/   (props changed)
>>   stable/8/sys/dev/xen/xenpci/   (props changed)
>>
>> Modified: stable/8/sys/net80211/ieee80211_rssadapt.c
>>
>> ==============================================================================
>> --- stable/8/sys/net80211/ieee80211_rssadapt.c  Sat Nov 20 13:12:59 2010
>>      (r215562)
>> +++ stable/8/sys/net80211/ieee80211_rssadapt.c  Sat Nov 20 13:24:05 2010
>>      (r215563)
>> @@ -58,12 +58,12 @@ struct rssadapt_expavgctl {
>>  };
>>
>>  static struct rssadapt_expavgctl master_expavgctl = {
>> -       rc_decay_denom : 16,
>> -       rc_decay_old : 15,
>> -       rc_thresh_denom : 8,
>> -       rc_thresh_old : 4,
>> -       rc_avgrssi_denom : 8,
>> -       rc_avgrssi_old : 4
>> +       .rc_decay_denom = 16,
>> +       .rc_decay_old = 15,
>> +       .rc_thresh_denom = 8,
>> +       .rc_thresh_old = 4,
>> +       .rc_avgrssi_denom = 8,
>> +       .rc_avgrssi_old = 4
>>  };
>>
>>  #ifdef interpolate
>> _______________________________________________
>> svn-src-all@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/svn-src-all
>> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>



-- 
Not so young, but still crying out
Full of anger full of doubt



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikK7mbNkKUWUUBQKyTOaKWaPqNzforr3ZCZa6RS>