Date: Tue, 29 Sep 2009 18:00:05 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Marcel Moolenaar <xcllnt@mac.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r197608 - head/sys/geom/part Message-ID: <alpine.BSF.2.00.0909291759180.94746@fledge.watson.org> In-Reply-To: <1F22EA6A-2793-45CE-9669-3FFD550CF4E2@mac.com> References: <200909282352.n8SNql1n069970@svn.freebsd.org> <200909290749.08764.jhb@freebsd.org> <1F22EA6A-2793-45CE-9669-3FFD550CF4E2@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 29 Sep 2009, Marcel Moolenaar wrote: >> Why do you check for zeros at all? AFAIK, the only real check is for AA55 >> at the end of the sector (and having an MBR or other Extended MBR partition >> entry point at the sector in question). The '96' thing seems rather >> arbitrary in the code, and I think the zero's check is overly restrictive. > > Only checking for a signature that 99% of the boot blocks have isn't enough. > The msdos file system has that signature and the check for all-zeroes is to > prevent false positives there. And, as I recall, the msdosfs check has been gradually getting weaker over time as the constraints it places on things like cylinder counts become obsolete. It's not quite that we'll mount msdosfs on any random pile of bytes, but it might be getting there... Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0909291759180.94746>