Date: Fri, 13 Jun 2003 19:10:23 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Erik Greenwald <erik@smluc.org> Cc: freebsd-stable@freebsd.org Subject: Re: problem with libc_r (uthread_close.c) in 4.8-STABLE Message-ID: <20030613161022.GB7382@sunbay.com> In-Reply-To: <20030613154416.GA16636@xarx.midsouth.rr.com> References: <20030613225435.X28265@nero.fastlane.net.au> <3EE9E9A5.4090702@electricjellyfish.net> <20030613154416.GA16636@xarx.midsouth.rr.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--jousvV0MzM2p6OtC
Content-Type: multipart/mixed; boundary="rJwd6BRFiFCcLxzm"
Content-Disposition: inline
--rJwd6BRFiFCcLxzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jun 13, 2003 at 10:44:16AM -0500, Erik Greenwald wrote:
> On Fri, Jun 13, 2003 at 11:11:33AM -0400, Garrett Rooney wrote:
> > Paul Reece wrote:
>=20
> <snip>
>=20
> >=20
> > Umh, you want 'fclose(file)', right? Since file is a FILE *, not a fil=
e=20
> > descriptor.
>=20
> yes, the configure script for mysql is wrong... however, the proper behav=
ior
> for close() if fed a junk value isn't a segfault, it's to set the errno a=
nd
> return a -1... compiling the test program without -libc_r lets it behave
> normally, with -libc_r causes sig11... (there's a ports pr on this from
> a couple days ago)
>=20
I've just merged the fix for this into RELENG_4 (commit log is attached).
Please let me know the PR number, so I could close it.
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
--rJwd6BRFiFCcLxzm
Content-Type: message/rfc822
Content-Disposition: inline
Received: from whale.sunbay.crimea.ua (root@localhost)h5DG5SC3008877
for <ru@sunbay.crimea.ua>; Fri, 13 Jun 2003 19:05:28 +0300 (EEST)
(envelope-from owner-src-committers@FreeBSD.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119])
h5DG5PuY008869
for <ru@sunbay.crimea.ua>; Fri, 13 Jun 2003 19:05:27 +0300 (EEST)
(envelope-from owner-src-committers@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])
by mx2.freebsd.org (Postfix) with ESMTP id D883A56C89
for <ru@sunbay.crimea.ua>; Fri, 13 Jun 2003 09:05:23 -0700 (PDT)
(envelope-from owner-src-committers@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
id 21BFC37B42B; Fri, 13 Jun 2003 09:05:22 -0700 (PDT)
Delivered-To: ru@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 538)
id 1408437B404; Fri, 13 Jun 2003 09:05:02 -0700 (PDT)
Delivered-To: src-committers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP
id 146BA37B401; Fri, 13 Jun 2003 09:05:00 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
by mx1.FreeBSD.org (Postfix) with ESMTP
id A767543F3F; Fri, 13 Jun 2003 09:04:59 -0700 (PDT)
(envelope-from ru@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h5DG4x0U003089;
Fri, 13 Jun 2003 09:04:59 -0700 (PDT)
(envelope-from ru@repoman.freebsd.org)
Received: (from ru@localhost)
by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h5DG4xaH003088;
Fri, 13 Jun 2003 09:04:59 -0700 (PDT)
Message-Id: <200306131604.h5DG4xaH003088@repoman.freebsd.org>
From: Ruslan Ermilov <ru@FreeBSD.org>
Date: Fri, 13 Jun 2003 09:04:59 -0700 (PDT)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/lib/libc_r/uthread uthread_close.c
X-FreeBSD-CVS-Branch: RELENG_4
Sender: owner-src-committers@FreeBSD.org
Precedence: bulk
X-Loop: FreeBSD.ORG
ru 2003/06/13 09:04:59 PDT
FreeBSD src repository
Modified files: (Branch: RELENG_4)
lib/libc_r/uthread uthread_close.c
Log:
MFC: 1.16: Range check "fd" before using it as an array index.
Revision Changes Path
1.10.2.5 +2 -1 src/lib/libc_r/uthread/uthread_close.c
--rJwd6BRFiFCcLxzm--
--jousvV0MzM2p6OtC
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+6fduUkv4P6juNwoRAvM7AJ9iUERADOuElXbfJUY7nyJrM1T0ZACeOFYP
etZ1rCNwe8Dr+dmLfziGLy4=
=o2qB
-----END PGP SIGNATURE-----
--jousvV0MzM2p6OtC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030613161022.GB7382>