Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Jun 2023 19:07:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 271991] Crash on some network packets with fresh stable
Message-ID:  <bug-271991-227-c5lABdeTEE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-271991-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-271991-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271991

--- Comment #6 from Mark Johnston <markj@FreeBSD.org> ---
So to fix the immediate problem (i.e., the crash):
- ng_bpf should stop copying/pulling up unless "usejit" is set.  bpf_filter=
()
can handle mbuf chains, it doesn't require a contiguous buffer.  Note that
bpf_mtap() and bpf_mtap2() do not do any pullups or copying.

Then:
- Make bpf handle unmapped mbufs.  Note that with unmapped mbufs, protocol
headers will still be mapped, so to trigger any problem you need a BPF prog=
ram
which reaches into the TCP payload.

Bonus points:
- Teach virtio-net (and probably other paravirtualized NIC drivers, like ena
and gve?) to handle unmapped mbufs.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271991-227-c5lABdeTEE>