Date: Tue, 12 Nov 2024 15:18:21 -0500 From: John Baldwin <jhb@FreeBSD.org> To: jlduran@freebsd.org, Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1fa6daaafd74 - main - ipfilter: Avoid stopping with a lock held Message-ID: <dae26e01-6fe0-4c76-b8cb-53a754ddf229@FreeBSD.org> In-Reply-To: <CAPwQLccpVdjUKQbCVQ0Vg5yRnmYSeKh%2Bb%2BThJwQY=z8OCZGOAw@mail.gmail.com> References: <202411120347.4AC3lPOA015167@gitrepo.freebsd.org> <09923ad3-4065-4a31-b35f-74f84e09cff1@FreeBSD.org> <20241112155219.2E15A2DF@slippy.cwsent.com> <20241112160243.B372532F@slippy.cwsent.com> <CAPwQLccpVdjUKQbCVQ0Vg5yRnmYSeKh%2Bb%2BThJwQY=z8OCZGOAw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/12/24 10:35, Jose Luis Duran wrote: > What would be the recommended approach in this case? > Revert, and commit with the fixes, or just fix the problematic code. > > At any rate, I have created https://reviews.freebsd.org/D47530. Feel > free to commandeer it, as my testing is limited to what's currently in > the "Test Plan". I was not able to recreate the deadlock described > here, but it definitely makes sense. There is no deadlock in this case because it is recursing on a shared lock. FWIW, I think your review is fine, and I would have been ok with just committing that instead of reverting everything. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dae26e01-6fe0-4c76-b8cb-53a754ddf229>