Date: Mon, 13 Jun 2022 14:18:55 -0700 From: Eric Joyner <erj@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 Message-ID: <CAKdFRZibhP3Ap_S_Gj=CY3uhVdLxkS2C%2BaeqfZf18wyn==TUiA@mail.gmail.com> In-Reply-To: <c0b2824f-6386-b8ba-90f3-f347155ba87b@FreeBSD.org> References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> <c0b2824f-6386-b8ba-90f3-f347155ba87b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Jun 10, 2022 at 3:29 PM John Baldwin <jhb@freebsd.org> wrote: > On 5/23/22 4:54 PM, Eric Joyner wrote: > > The branch main has been updated by erj: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef > > > > commit cdcd52d41e246ba1c0fcfad0769bd691487355ef > > Author: Bartosz Sobczak <bartosz.sobczak@intel.com> > > AuthorDate: 2022-05-23 23:39:27 +0000 > > Commit: Eric Joyner <erj@FreeBSD.org> > > CommitDate: 2022-05-23 23:52:49 +0000 > > > > irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 > > > > This is an initial commit for RDMA FreeBSD driver for Intel(R) > Ethernet > > Controller E810, called irdma. Supporting both RoCEv2 and iWARP > > protocols in per-PF manner, RoCEv2 being the default. > > > > Testing has been done using krping tool, perftest, ucmatose, rping, > > ud_pingpong, rc_pingpong and others. > > > > Signed-off-by: Eric Joyner <erj@FreeBSD.org> > > > > Reviewed by: #manpages (pauamma_gundo.com) [documentation] > > MFC after: 1 week > > Relnotes: yes > > Sponsored by: Intel Corporation > > Differential Revision: https://reviews.freebsd.org/D34690 > > I'm trying to get the tree building again with GCC and ld.bfd does not like > libirdma.map at all complaining with an error: > > duplicate expression '*' in version information > > I looked at the version map, and it seems rather bogus to me and not like > version maps used anywhere else. It seems to be exporting all symbols in > two different versions? That would seem to defeat the point of having > symbol versions? > > /* Export symbols should be added below according to > Documentation/versioning.md document. */ > IRDMA_1.0 { > global: *; > local: *; > }; > > IRDMA_1.1 { > global: *; > } IRDMA_1.0; > > (I'm also not sure why lld accepts such a version map.) > > -- > John Baldwin > Hi, I don't know how to answer this; I'm going to forward this to the FreeBSD RDMA guy and another one (the first guy might still be out on vacation) and see if they can answer this. - Eric [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Fri, Jun 10, 2022 at 3:29 PM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 5/23/22 4:54 PM, Eric Joyner wrote:<br> > The branch main has been updated by erj:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef</a><br>; > <br> > commit cdcd52d41e246ba1c0fcfad0769bd691487355ef<br> > Author: Bartosz Sobczak <<a href="mailto:bartosz.sobczak@intel.com" target="_blank">bartosz.sobczak@intel.com</a>><br> > AuthorDate: 2022-05-23 23:39:27 +0000<br> > Commit: Eric Joyner <erj@FreeBSD.org><br> > CommitDate: 2022-05-23 23:52:49 +0000<br> > <br> > irdma: Add RDMA driver for Intel(R) Ethernet Controller E810<br> > <br> > This is an initial commit for RDMA FreeBSD driver for Intel(R) Ethernet<br> > Controller E810, called irdma. Supporting both RoCEv2 and iWARP<br> > protocols in per-PF manner, RoCEv2 being the default.<br> > <br> > Testing has been done using krping tool, perftest, ucmatose, rping,<br> > ud_pingpong, rc_pingpong and others.<br> > <br> > Signed-off-by: Eric Joyner <erj@FreeBSD.org><br> > <br> > Reviewed by: #manpages (<a href="http://pauamma_gundo.com" rel="noreferrer" target="_blank">pauamma_gundo.com</a>) [documentation]<br> > MFC after: 1 week<br> > Relnotes: yes<br> > Sponsored by: Intel Corporation<br> > Differential Revision: <a href="https://reviews.freebsd.org/D34690" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D34690</a><br>; <br> I'm trying to get the tree building again with GCC and ld.bfd does not like<br> libirdma.map at all complaining with an error:<br> <br> duplicate expression '*' in version information<br> <br> I looked at the version map, and it seems rather bogus to me and not like<br> version maps used anywhere else. It seems to be exporting all symbols in<br> two different versions? That would seem to defeat the point of having<br> symbol versions?<br> <br> /* Export symbols should be added below according to<br> Documentation/versioning.md document. */<br> IRDMA_1.0 {<br> global: *;<br> local: *;<br> };<br> <br> IRDMA_1.1 {<br> global: *;<br> } IRDMA_1.0;<br> <br> (I'm also not sure why lld accepts such a version map.)<br> <br> -- <br> John Baldwin<br></blockquote><div><br></div><div>Hi,</div><div><br></div><div>I don't know how to answer this; I'm going to forward this to the FreeBSD RDMA guy and another one (the first guy might still be out on vacation) and see if they can answer this.</div><div><br></div><div>- Eric</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKdFRZibhP3Ap_S_Gj=CY3uhVdLxkS2C%2BaeqfZf18wyn==TUiA>