Date: Fri, 14 May 2021 11:10:03 -0500 From: Warner Losh <imp@bsdimp.com> To: Marc Veldman <marc@bumblingdork.com> Cc: Henri Hennebert <hlh@restart.be>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: CURRENT crashes at early boot on Lenovo T540p: rtsx to blame - 13.0-RELEASE crashes same way! Message-ID: <CANCZdfp28=yaOWd7HZzycMbA9cskRoO2UBNpwiTE2n0qaX0SrQ@mail.gmail.com> In-Reply-To: <EDEBD9DE-083C-4CAC-9D4B-A1E15201A945@bumblingdork.com> References: <a7363387-c53f-d6c0-acc0-be9081590ea1@FreeBSD.org> <8d2be5f2-4144-082e-4237-0dac0c4b37e6@restart.be> <f084b1c8-5020-2db9-6cf3-47641066bb69@FreeBSD.org> <6798878a-c499-d78d-e96d-d744513cb80d@restart.be> <a630c8a3-a9d7-c6f5-111c-be0e64db1ec6@FreeBSD.org> <1de588e2-20cb-3206-3aea-f3f88f577675@restart.be> <c324501a-6a8e-f8aa-3ecd-e8d7d3485e2c@FreeBSD.org> <e20d2d7d-8584-bb6b-465d-83a5b63f8210@restart.be> <67f0874a-6a05-67f1-3f2b-c4b3dc67fa11@FreeBSD.org> <83b823bf-c6c2-2f6a-b5dd-2e91b4d1931e@restart.be> <2c208bbc-5adc-2327-4717-a5e7c8d64b4b@FreeBSD.org> <9a15daa7-2b17-e257-d4d1-850c632a9db8@restart.be> <417a97b9-2c40-310c-c445-b193c493b880@FreeBSD.org> <7eb763ce-0bbf-9baf-2ede-968ee25cff2e@restart.be> <ac486329-36cf-1a3d-063e-d89b174e2f14@FreeBSD.org> <b39d89b0-5576-c7e0-614f-9c7aad228d9d@restart.be> <0CA59364-6802-4733-962A-3EEB00B43AFE@bumblingdork.com> <20210514144830.6b19de85@ernst.home> <51290711-0DC5-45DD-B2DB-4C2D98667DC7@bumblingdork.com> <c27a57ae-a458-ab5a-fdae-9915c7481803@restart.be> <EDEBD9DE-083C-4CAC-9D4B-A1E15201A945@bumblingdork.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 14, 2021, 11:03 AM Marc Veldman <marc@bumblingdork.com> wrote: > > > > On 14 May 2021, at 17:29, Henri Hennebert <hlh@restart.be> wrote: > > > > On 5/14/21 5:05 PM, Marc Veldman wrote: > >>> On 14 May 2021, at 16:48, Gary Jennejohn <gljennjohn@gmail.com> wrote: > >>> > >>> On Fri, 14 May 2021 16:21:05 +0200 > >>> Marc Veldman <marc@bumblingdork.com> wrote: > >>> > >>>>> On 14 May 2021, at 10:22, Henri Hennebert <hlh@restart.be> wrote: > >>>>> > >>>>> > >>>>> Please test the 2.0h version from GitHub. > >>>>> > >>>> > >>>> On my Lenovo P50s: > >>>> > >>>> Cold boot with card not inserted: OK > >>>> Insert card after boot, no crash, but the message > >>>> seems weird: > >>>> > >>>> May 14 16:01:27 supernovo kernel: rtsx0: Interrupt card > inserted/removed > >>>> May 14 16:01:27 supernovo kernel: rtsx0: Card absent > >>>> May 14 16:01:27 supernovo kernel: mmc0: detached > >>>> > >>>> Cold boot with card inserted: OK > >>>> Remove card after boot, no crash, but the message > >>>> seems weird: > >>>> > >>>> May 14 16:06:08 supernovo kernel: rtsx0: Interrupt card > inserted/removed > >>>> May 14 16:06:08 supernovo kernel: rtsx0: Card present > >>>> May 14 16:06:08 supernovo kernel: mmc0: <MMC/SD bus> on rtsx0 > >>>> > >>>> I have the inversion flag turned on /boot/loader.conf > >>>> > >>>> dev.rtsx.0.inversion=1 > >>>> dev.rtsx.0.debug=1 > >>>> > >>> > >>> This is weird because the man page states that the inversion flag is > >>> required with the P50. > >>> > >>> BTW Henri, if you're reading this, there's a bug in exactly this part > >>> of the man page: sovled rather than solved > > > > Thank you for the hint - will be corrected in the next push. > > > >>> > >>> But, the trace output indicates that you do not need the inversion > flag. > >>> > >>> Maybe your P50 (may be a later model than the P50s tested during driver > >>> development) does not have the problem. > >> I removed the flag, and it works now.Thanks! > >> What is it in the trace that indicated that the inversion flag is not > needed? > > > > In Bug 255130 they ask me to automate the inversion. I do it for the > P50s and T470p following informations from Bug 204521. > > > > But strangely it is not applicable to this particular P50s. So, as > indicated in my previous mail, it must be nullify with > dev.rtsx.0.inversion=0. > > > > To investigate this last problem can you send > > > > kenv | grep smbios.system > > > marc@supernovo:~ $ kenv | grep smbios.system > smbios.system.family="ThinkPad P50s" > smbios.system.maker="LENOVO" > smbios.system.product="20FLCTO1WW" > smbios.system.serial="R90N30VP" > smbios.system.sku="LENOVO_MT_20FL_BU_Think_FM_ThinkPad P50s" > smbios.system.uuid="cbc5ee4c-2b18-11b2-a85c-a62da394388c" > smbios.system.version="ThinkPad P50s" > marc@supernovo:~ $ > If there are only a few systems that need inversion, then using these things to do that by default is a nice to have item. Warner > > > and > > > > dmesg|grep rtsx > > > > > rtsx0: <2.0h Realtek RTS522A PCI MMC/SD Card Reader> mem > 0xf4100000-0xf4100fff at device 0.0 on pci1 > rtsx0: Inversion activated for LENOVO/ThinkPad P50s/20FLCTO1WW, see BUG in > rtsx(4) > rtsx0: If a card is detected without an SD card present, add > dev.rtsx.0.inversion=0 in loader.conf(5) > rtsx0: We are running with inversion: 0 > rtsx0: Interrupt card inserted/removed > rtsx0: Card present > rtsx0: A card is detected > mmc0: <MMC/SD bus> on rtsx0 > rtsx0: Interrupt card inserted/removed > rtsx0: Card absent > rtsx0: Interrupt card inserted/removed > rtsx0: Card present > mmc0: <MMC/SD bus> on rtsx0 > rtsx0: Interrupt card inserted/removed > rtsx0: Card absent > > Best regards, > > Marc Veldman > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp28=yaOWd7HZzycMbA9cskRoO2UBNpwiTE2n0qaX0SrQ>