Date: Tue, 21 Jun 2011 11:17:43 -0500 From: Guy Helmer <guy.helmer@palisadesystems.com> To: Jack Vogel <jfvogel@gmail.com> Cc: Jack F Vogel <jfv@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r223350 - head/sys/dev/e1000 Message-ID: <5B6CCF15-05B9-418A-8B84-6A2FF441A39C@palisadesystems.com> In-Reply-To: <BANLkTim-_hqXBC=3oC2dwi7YxC7aSJ_BPg@mail.gmail.com> References: <201106202259.p5KMxT1h069297@svn.freebsd.org> <201106210907.18414.jhb@freebsd.org> <BANLkTim-_hqXBC=3oC2dwi7YxC7aSJ_BPg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: > LOL, the old adage is true, you just can't please all the people... :)=20= >=20 > The way the code now is it assigns a default, but you could still have > a loader entry that would change it for all adapters if you wanted to, > but ok, if you prefer the older for this. What other globals do you=20 > think should be retained? >=20 I'd like to be able to set the global default for flow control. I'd = also appreciate a global default for disabling TCP checksum offload, but = that's above and beyond what we had before :-) > Jack >=20 >=20 > On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin <jhb@freebsd.org> wrote: > On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: > > Author: jfv > > Date: Mon Jun 20 22:59:29 2011 > > New Revision: 223350 > > URL: http://svn.freebsd.org/changeset/base/223350 > > > > Log: > > Eliminate some global tuneables in favor of adapter-specific, > > particular flow control and dma coalesce. Also improve the > > sysctl operation on those too. > > > > Add IPv6 detection in the ioctl code, this was done for > > ixgbe first, carrying that over. > > > > Add resource ability to disable particular adapter. > > > > Add HW TSO capability so vlans can make use of TSO >=20 > The tunables are useful for setting defaults for all interfaces. :( >=20 > I use hw.igb.rx_processing_limit=3D-1 in loader.conf at work so that = we can > ensure that all igb interfaces in a given system have that setting. = This is > more scalable than having to set the right number of entries in > /etc/sysctl.conf.local on different machines, etc, without spamming = the > console during boot with warnings about tweaking non-existing sysctls, = etc. >=20 > Please consider keeping the tunables where the tunables are used to = set > default settings for all adapters from the loader but per-device = sysctls are > used post-boot to provide runtime, per-device settings. >=20 > -- > John Baldwin >=20 --------=0AThis message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.=0A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B6CCF15-05B9-418A-8B84-6A2FF441A39C>