Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 May 2020 23:05:29 -0700
From:      John-Mark Gurney <jmg@funkthat.com>
To:        Mateusz Guzik <mjguzik@gmail.com>
Cc:        vbox@freebsd.org, freebsd-virtualization@freebsd.org
Subject:   Re: patch to make vboxvfs work again
Message-ID:  <20200510060529.GO4213@funkthat.com>
In-Reply-To: <CAGudoHFef7JPDhtSs1750_FXbX4baHN3%2BoO=jxnfRADFfMmk2g@mail.gmail.com>
References:  <20200509203336.GN4213@funkthat.com> <CAGudoHFef7JPDhtSs1750_FXbX4baHN3%2BoO=jxnfRADFfMmk2g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Mateusz Guzik wrote this message on Sat, May 09, 2020 at 23:17 +0200:
> That will do the trick indeed.
> 
> I don't know about that bcmp thingy, ideally it would be needed. I
> presume there is a sufficient header mess which makes this to be the
> easiest hack.

Yeah.  It appears that they compile libraries w/o the kernel headers
and then link those files into the kernel module wrapper...

I did notice that we mistakenly still have a prototype for bcmp in
sys/systm.h even though that function get's #defined to a builtin
instead...

> On 5/9/20, John-Mark Gurney <jmg@funkthat.com> wrote:
> > Hello virtualbox maintainer(s),
> >
> > Attached is a patch to make VirtualBox vboxvfs work again.  I've only
> > tested under -current.
> >
> > mjg, what is the correct way to make this patch work on past versions
> > of FreeBSD?  would a simple #ifdef VFS_VOP_VECTOR_REGISTER wrapper
> > around the call work?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200510060529.GO4213>