Date: Tue, 4 Jun 2024 11:33:43 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9b8db66402e9 - main - netgraph: provide separate malloc type for nodes that are missing it Message-ID: <Zl9eBxOKnnx0WBrX@cell.glebi.us> In-Reply-To: <ZloQ5HpJa27AWVP4@spindle.one-eyed-alien.net> References: <202405311620.44VGK2xX033356@gitrepo.freebsd.org> <ZloQ5HpJa27AWVP4@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 31, 2024 at 06:03:16PM +0000, Brooks Davis wrote: B> > Author: Dmitry Lukhtionov <dmitryluhtionov@gmail.com> B> > AuthorDate: 2024-05-31 16:19:54 +0000 B> > Commit: Gleb Smirnoff <glebius@FreeBSD.org> B> > CommitDate: 2024-05-31 16:19:54 +0000 B> > B> > netgraph: provide separate malloc type for nodes that are missing it B> > B> > The kernel option NG_SEPARATE_MALLOC helps to debug memory leaks in B> > netgraph(4). Several nodes were missing the support. B> B> I realize this commit didn't create the option, but is there really B> enough of a cost to having multiple malloc types to justify an option at B> all? This is just how it has been since early days of netgraph, and it makes some missing nodes to honor the flag, thus I just accepted the submission. I have no objection if afedorov@ or anybody else takes a more thoughful evaluation and changes that. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zl9eBxOKnnx0WBrX>