Date: Sat, 8 Jul 2023 18:18:07 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Raphael Kubo da Costa <rakuco@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ae8e32b08e33 - main - devel/qjson: Improve clang 16 workaround for usage of the 'register' keyword Message-ID: <ZKmoX_4Lz4_zC3Hn@FreeBSD.org> In-Reply-To: <202307080950.3689opPW096575@gitrepo.freebsd.org> References: <202307080950.3689opPW096575@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 08, 2023 at 09:50:51AM +0000, Raphael Kubo da Costa wrote:
> commit ae8e32b08e33bac7aec0f14f28e45d53dee6f565
>
> devel/qjson: Improve clang 16 workaround for usage of the 'register'
> keyword
>
> Commit 3237ce1557467a3f89a3d1fa7a9308161665bf0c fixed the build on
> CURRENT with a heavy hammer that made register a macro. This change
> passes -Wno-register to the compiler instead, which is cleaner.
Correct fix is still like the following one-liner (untested):
${REINPLACE_CMD} -e 's,register ,,' ${WRKSRC}/src/json_scanner.cc
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZKmoX_4Lz4_zC3Hn>