Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Jun 2012 18:10:13 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r236903 - stable/8/sys/kern
Message-ID:  <201206111810.q5BIAD6a001805@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Mon Jun 11 18:10:12 2012
New Revision: 236903
URL: http://svn.freebsd.org/changeset/base/236903

Log:
  MFC r236738:
  	Plug socket refcount leak on error in sys_sctp_peeloff.

Modified:
  stable/8/sys/kern/uipc_syscalls.c
Directory Properties:
  stable/8/sys/   (props changed)

Modified: stable/8/sys/kern/uipc_syscalls.c
==============================================================================
--- stable/8/sys/kern/uipc_syscalls.c	Mon Jun 11 18:09:04 2012	(r236902)
+++ stable/8/sys/kern/uipc_syscalls.c	Mon Jun 11 18:10:12 2012	(r236903)
@@ -2302,11 +2302,11 @@ sctp_peeloff(td, uap)
 		goto done2;
 	if (head->so_proto->pr_protocol != IPPROTO_SCTP) {
 		error = EOPNOTSUPP;
-		goto done2;
+		goto done;
 	}
 	error = sctp_can_peel_off(head, (sctp_assoc_t)uap->name);
 	if (error)
-		goto done2;
+		goto done;
 	/*
 	 * At this point we know we do have a assoc to pull
 	 * we proceed to get the fd setup. This may block



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206111810.q5BIAD6a001805>