Date: Tue, 5 May 2009 01:22:12 +0200 From: Lucius Windschuh <lwindschuh@googlemail.com> To: Alexander Motin <mav@freebsd.org> Cc: freebsd-current@freebsd.org, freebsd-mobile@freebsd.org Subject: Re: Fighting for the power. Message-ID: <90a5caac0905041622oaddd7cek52f28a9b018b3ea7@mail.gmail.com> In-Reply-To: <49FF6C11.5030607@FreeBSD.org> References: <49FE1826.4060000@FreeBSD.org> <90a5caac0905041119h70101d12i56863e57b27d2e55@mail.gmail.com> <49FF6C11.5030607@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/5/5 Alexander Motin <mav@freebsd.org>:
> Lucius Windschuh wrote:
>> [...]
>> panic: lapic1: zero divisor
> [...]
> --- local_apic.c.prev =A0 2009-05-01 23:53:37.000000000 +0300
> +++ local_apic.c =A0 =A0 =A0 =A02009-05-05 01:10:04.000000000 +0300
> @@ -319,7 +319,7 @@ lapic_setup(int boot)
> =A0 =A0 =A0 =A0}
>
> =A0 =A0 =A0 =A0/* We don't setup the timer during boot on the BSP until l=
ater. */
> - =A0 =A0 =A0 if (!(boot && PCPU_GET(cpuid) =3D=3D 0)) {
> + =A0 =A0 =A0 if (!(boot && PCPU_GET(cpuid) =3D=3D 0) && lapic_timer_hz !=
=3D 0) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0KASSERT(lapic_timer_period !=3D 0, ("lapic=
%u: zero divisor",
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0lapic_id()));
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0lapic_timer_set_divisor(lapic_timer_diviso=
r);
This patch solves the panic.
C3 instead of C2 saves between 0.5 and 1.5 Watt here with some quick
measurements.
Thanks.
Lucius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?90a5caac0905041622oaddd7cek52f28a9b018b3ea7>