Date: Tue, 29 Nov 2011 19:47:27 -0500 From: Sahil Tandon <sahil+cvs-ports@tandon.net> To: Mark Linimon <linimon@lonesome.com> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Michael Scheidell <scheidell@FreeBSD.org> Subject: Re: cvs commit: ports/net-mgmt/flow-tools Makefile Message-ID: <20111130004727.GB4223@magic.hamla.org> In-Reply-To: <20111129033401.GA11234@lonesome.com> References: <201111281622.pASGMV6L052569@repoman.freebsd.org> <20111129014942.GB3706@magic.hamla.org> <20111129033401.GA11234@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2011-11-28 at 21:34:01 -0600, Mark Linimon wrote: > On Mon, Nov 28, 2011 at 08:49:42PM -0500, Sahil Tandon wrote: > > > Submitted by: fw@moov.de > > > Reviewed by: scheidell > > > Approved by: maintainer (fw@moov.de, timeout), gabor (mentor) > > > > What is the rationale for placing the submitter's name in the maintainer > > timeout 'Approved by:' tag? > > fwiw, portsmon looks for "maintainer.timeout" to help it track such > things, so I'd prefer to see "fw@moov.de (maintainer timeout)". Style considerations aside, fm@moov.de is not the maintainer (this port has none), but rather the submitter of the PR. -- Sahil Tandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111130004727.GB4223>