Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jun 1998 10:46:07 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        dfr@FreeBSD.ORG, jb@cimlogic.com.au
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/conf options src/sys/ddb db_aout.c db_break.c         db_break.h db_examine.c db_lex.c db_output.c db_print.
Message-ID:  <199806080046.KAA00361@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>This is going to keep Bruce busy for a while. 8-)

A before-commit review reduced it to a manageable size :-).

>> dfr         1998/06/07 10:13:16 PDT
>> ...
>>   Modified files:
>>     sys/kern             imgact_elf.c init_main.c kern_conf.c 
>>                          kern_exec.c kern_intr.c kern_lkm.c 
>>                          kern_shutdown.c kern_sig.c kern_subr.c 
>>                          link_aout.c makesyscalls.sh md5c.c 
>>                          subr_log.c subr_xxx.c sys_pipe.c 
>>                          sys_process.c sys_socket.c 
>>                          syscalls.master tty.c tty_compat.c 
                            ^^^^^^^^^^^^^^^
>>                          tty_conf.c tty_pty.c tty_snoop.c 
>>                          tty_tty.c uipc_socket2.c vfs_lookup.c 
>>                          vfs_subr.c vfs_syscalls.c vfs_vnops.c 
>> ...
>>     sys/sys              conf.h disklabel.h file.h imgact_elf.h 
>>                          ioccom.h kernel.h namei.h param.h 
>>                          protosw.h ptrace.h socketvar.h sysent.h 
>>                          sysproto.h systm.h tty.h types.h 
                            ^^^^^^^^^^

The most obvious bug is incorrect bootstrapping of generated files.
Generated files can't be committed in the same batch as the sources
that they are generated from, since the commit will changes the Ids
in the sources, leaving garbage references to the Ids in generated
files.  Some generated files (e.g., kern/syscalls.c) were not committed
because they didn't change when generated by the old sources, but they
will change when they are regenerated.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806080046.KAA00361>