Date: Tue, 11 Oct 2011 13:26:26 +0200 From: Giovanni Trematerra <giovanni.trematerra@gmail.com> To: Christian Brueffer <brueffer@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226247 - head/sys/compat/linux Message-ID: <CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p%2Bw@mail.gmail.com> In-Reply-To: <201110111032.p9BAWNpw011158@svn.freebsd.org> References: <201110111032.p9BAWNpw011158@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 11, 2011 at 12:32 PM, Christian Brueffer <brueffer@freebsd.org> wrote: > Author: brueffer > Date: Tue Oct 11 10:32:23 2011 > New Revision: 226247 > URL: http://svn.freebsd.org/changeset/base/226247 > > Log: > Properly free linux_gidset in case of an error. > > CID: 4136 > Found with: Coverity Prevent(tm) > MFC after: 1 week > > Modified: > head/sys/compat/linux/linux_uid16.c > > Modified: head/sys/compat/linux/linux_uid16.c > ============================================================================== > --- head/sys/compat/linux/linux_uid16.c Tue Oct 11 07:46:45 2011 (r226246) > +++ head/sys/compat/linux/linux_uid16.c Tue Oct 11 10:32:23 2011 (r226247) > @@ -114,6 +114,7 @@ linux_setgroups16(struct thread *td, str > linux_gidset = malloc(ngrp * sizeof(*linux_gidset), M_TEMP, M_WAITOK); > error = copyin(args->gidset, linux_gidset, ngrp * sizeof(l_gid16_t)); > if (error) > + free(linux_gidset, M_TEMP); > return (error); > newcred = crget(); > p = td->td_proc; Did you miss { } ? -- Gianni
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p%2Bw>