Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jan 2024 17:35:44 +0100
From:      FreeBSD User <freebsd@walstatt-de.de>
To:        Peter Blok <pblok@bsd4all.org>
Cc:        Cy Schubert <Cy.Schubert@cschubert.com>, Rick Macklem <rick.macklem@gmail.com>, Ronald Klop <ronald-lists@klop.ws>, FreeBSD CURRENT <freebsd-current@freebsd.org>
Subject:   Re: NFSv4 crash of CURRENT
Message-ID:  <20240115173611.2b8e76d6@thor.intern.walstatt.dynvpn.de>
In-Reply-To: <683EF50F-6665-4664-A7CE-1EFE50076FB0@bsd4all.org>
References:  <20240113193324.3fd54295@thor.intern.walstatt.dynvpn.de> <1369645989.13766.1705178331205@localhost> <CAM5tNy5aat8vUn2fsX9jV=D9yGZdnO20Q0Ea7qtszx%2BzSES2bw@mail.gmail.com> <20240115043412.B6998C8@slippy.cwsent.com> <20240115064704.611fe0c4@thor.intern.walstatt.dynvpn.de> <D6D597BF-A98B-4864-B754-CB0B9A7A5A66@bsd4all.org> <683EF50F-6665-4664-A7CE-1EFE50076FB0@bsd4all.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Am Mon, 15 Jan 2024 11:53:31 +0100
Peter Blok <pblok@bsd4all.org> schrieb:

> Hi,
>=20
> Forgot to mention I=E2=80=99m on 13-stable. The fix that is causing the c=
rash with automounted NFS
> is:
>=20
> commit cc5cda1dbaa907ce52074f47264cc45b5a7d6c8b
> Author: Konstantin Belousov <kib@FreeBSD.org>
> Date:   Tue Jan 2 00:22:44 2024 +0200
>=20
>     nfsclient: limit situations when we do unlocked read-ahead by nfsiod
>    =20
>     (cherry picked from commit 70dc6b2ce314a0f32755005ad02802fca7ed186e)
>=20
> When I remove the fix, the problem is gone. Add it back and the crash hap=
pens.
>=20
> Peter
>=20
> > On 15 Jan 2024, at 09:31, Peter Blok <pblok@bsd4all.org> wrote:
> >=20
> > Hi,
> >=20
> > I do have a crash on a NFS client with stable of today
> > (4c4633fdffbe8e4b6d328c2bc9bb3edacc9ab50a). It is also autofs related. =
Maybe it is the
> > same problem.
> >=20
> > I have ports automounted on /am/ports. When I do cd /am/ports/sys and t=
ype tab to
> > autocomplete it crashes with the below stack trace. If I plainly mount =
ports on /usr/ports
> > and do the same everything works. I am using NFSv3
> >=20
> > Peter
> >=20
> >=20
> >=20
> >=20
> > Fatal trap 12: page fault while in kernel mode
> > cpuid =3D 2; apic id =3D 04
> > fault virtual address	=3D 0x89
> > fault code		=3D supervisor read data, page not present
> > instruction pointer	=3D 0x20:0xffffffff809645d4
> > stack pointer	        =3D 0x28:0xfffffe00acadb830
> > frame pointer	        =3D 0x28:0xfffffe00acadb830
> > code segment		=3D base 0x0, limit 0xfffff, type 0x1b
> > 			=3D DPL 0, pres 1, long 1, def32 0, gran 1
> > processor eflags	=3D interrupt enabled, resume, IOPL =3D 0
> > current process		=3D 6869 (csh)
> > trap number		=3D 12
> > panic: page fault
> > cpuid =3D 2
> > time =3D 1705306940
> > KDB: stack backtrace:
> > #0 0xffffffff806232f5 at kdb_backtrace+0x65
> > #1 0xffffffff805d7a02 at vpanic+0x152
> > #2 0xffffffff805d78a3 at panic+0x43
> > #3 0xffffffff809d58ad at trap_fatal+0x38d
> > #4 0xffffffff809d58ff at trap_pfault+0x4f
> > #5 0xffffffff809af048 at calltrap+0x8
> > #6 0xffffffff804c7a7e at ncl_bioread+0xb7e
> > #7 0xffffffff804b9d90 at nfs_readdir+0x1f0
> > #8 0xffffffff8069c61a at vop_sigdefer+0x2a
> > #9 0xffffffff809f8ae0 at VOP_READDIR_APV+0x20
> > #10 0xffffffff81ce75de at autofs_readdir+0x2ce
> > #11 0xffffffff809f8ae0 at VOP_READDIR_APV+0x20
> > #12 0xffffffff806c3002 at kern_getdirentries+0x222
> > #13 0xffffffff806c33a9 at sys_getdirentries+0x29
> > #14 0xffffffff809d6180 at amd64_syscall+0x110
> > #15 0xffffffff809af95b at fast_syscall_common+0xf8
> >=20
> >=20
> >  =20
> >> On 15 Jan 2024, at 06:46, FreeBSD User <freebsd@walstatt-de.de
> >> <mailto:freebsd@walstatt-de.de>> wrote:
> >>=20
> >> Am Sun, 14 Jan 2024 20:34:12 -0800
> >> Cy Schubert <Cy.Schubert@cschubert.com <mailto:Cy.Schubert@cschubert.c=
om>> schrieb:
> >>  =20
> >>> In message <CAM5tNy5aat8vUn2fsX9jV=3DD9yGZdnO20Q0Ea7qtszx+zSES2bw@mai=
l.gmail.c
> >>> <mailto:CAM5tNy5aat8vUn2fsX9jV=3DD9yGZdnO20Q0Ea7qtszx+zSES2bw@mail.gm=
ail.c> =20
> >>> om>   =20
> >>> , Rick Macklem writes: =20
> >>>> On Sat, Jan 13, 2024 at 12:39=3DE2=3D80=3DAFPM Ronald Klop <ronald-l=
ists@klop.ws
> >>>> <mailto:ronald-lists@klop.ws>>=3D wrote:   =20
> >>>>>=20
> >>>>>=20
> >>>>> Van: FreeBSD User <freebsd@walstatt-de.de <mailto:freebsd@walstatt-=
de.de>>
> >>>>> Datum: 13 januari 2024 19:34
> >>>>> Aan: FreeBSD CURRENT <freebsd-current@freebsd.org <mailto:freebsd-c=
urrent@freebsd.org>>
> >>>>> Onderwerp: NFSv4 crash of CURRENT
> >>>>>=20
> >>>>> Hello,
> >>>>>=20
> >>>>> running CURRENT client (FreeBSD 15.0-CURRENT #4 main-n267556-69748e=
62e82a=3D   =20
> >>>> : Sat Jan 13 18:08:32   =20
> >>>>> CET 2024 amd64). One NFSv4 server is same OS revision as the mentio=
ned cl=3D   =20
> >>>> ient, other is FreeBSD   =20
> >>>>> 13.2-RELEASE-p8. Both offer NFSv4 filesystems, non-kerberized.
> >>>>>=20
> >>>>> I can crash the client reproducable by accessing the one or other N=
FSv4 F=3D   =20
> >>>> S (a simple ls -la).   =20
> >>>>> The NFSv4 FS is backed by ZFS (if this matters). I do not have phys=
icla a=3D   =20
> >>>> ccess to the client   =20
> >>>>> host, luckily the box recovers.   =20
> >>>> Did you rebuild both the nfscommon and nfscl modules from the same s=
ources?
> >>>> I did a commit to main that changes the interface between these two
> >>>> modules and did bump the
> >>>> __FreeBSD_version to 1500010, which should cause both to be rebuilt.
> >>>> (If you have "options NFSCL" in your kernel config, both should have
> >>>> been rebuilt as a part of
> >>>> the kernel build.)
> >>>>  =20
> >>>=20
> >>> Is anyone by chance seeing autofs in the backtrace too?
> >>>=20
> >>>  =20
> >>=20
> >> Hello Cy Shubert,
> >>=20
> >> I forgot to mention that those crashes occur with autofs mounted files=
ystems. Good
> >> question, by the way, I will check whether crashes also happen when mo=
unting the
> >> tradidional way.
> >>=20
> >> Kind regards,
> >>=20
> >> oh
> >>=20
> >> --=20
> >> O. Hartmann =20
> >  =20
>=20

good catch!

--=20
O. Hartmann



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240115173611.2b8e76d6>