Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Oct 2005 12:31:47 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Peter Holm <peter@holm.cc>
Cc:        current@FreeBSD.org
Subject:   Re: panic: mutex nfsd_mtx owned at nfsserver/nfs_serv.c:2160
Message-ID:  <20051026083147.GA41520@cell.sick.ru>
In-Reply-To: <20051026072337.GA31319@peter.osted.lan>
References:  <20051026072337.GA31319@peter.osted.lan>

next in thread | previous in thread | raw e-mail | index | archive | help

--3O1VwFp74L81IIeR
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline

  Peter,

On Wed, Oct 26, 2005 at 09:23:37AM +0200, Peter Holm wrote:
P> While stress testing RELENG_6_0 with a nfs mounted file system on a 
P> box running HEAD from Oct 24 13:21 UTC I got this panic (on HEAD):
P> http://people.freebsd.org/~pho/stress/log/nfsd.html

let's try out this one.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE

--3O1VwFp74L81IIeR
Content-Type: text/plain; charset=koi8-r
Content-Disposition: attachment; filename="nfs_serv.c.diff"

Index: nfs_serv.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsserver/nfs_serv.c,v
retrieving revision 1.156
diff -u -r1.156 nfs_serv.c
--- nfs_serv.c	17 Apr 2005 16:25:36 -0000	1.156
+++ nfs_serv.c	26 Oct 2005 08:00:26 -0000
@@ -2092,6 +2092,7 @@
 	tl = nfsm_dissect_nonblock(u_int32_t *, NFSX_UNSIGNED);
 	vtyp = nfsv3tov_type(*tl);
 	if (vtyp != VCHR && vtyp != VBLK && vtyp != VSOCK && vtyp != VFIFO) {
+		NFSD_UNLOCK();
 		error = NFSERR_BADTYPE;
 		goto out;
 	}
@@ -2108,6 +2109,7 @@
 	 * Iff doesn't exist, create it.
 	 */
 	if (nd.ni_vp) {
+		NFSD_UNLOCK();
 		error = EEXIST;
 		goto out;
 	}

--3O1VwFp74L81IIeR--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051026083147.GA41520>