Date: Sun, 5 Jun 2011 09:25:46 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: jhell@dataix.net, jharris@widomaker.com Cc: Robert Huff <roberthuff@rcn.com>, freebsd-ports@freebsd.org Subject: Re: Fping with WITH_IPV6=YES Message-ID: <BANLkTimB5V=jDUOxXbLoiuA2UsnP6TnZNA@mail.gmail.com> In-Reply-To: <20110605022434.GB46823@DataIX.net> References: <BANLkTi=y0j-rQUEnsn0eRnE-OHRy=H7VWg@mail.gmail.com> <20110603161358.GB1247@procyon.xvoid.org> <BANLkTikfPK0zs_8%2BV34vOfz13H9bdbVeGg@mail.gmail.com> <19946.7125.169246.84228@jerusalem.litteratus.org> <60F86515-B592-4B98-BE53-904206B6B183@lists.zabbadoz.net> <19946.11846.502201.644665@jerusalem.litteratus.org> <20110605012320.GA46823@DataIX.net> <20110605022434.GB46823@DataIX.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 4, 2011 at 9:24 PM, Jason Hellenthal <jhell@dataix.net> wrote:
>
> And if I might suggest, remove the old ifdef and replace with ...
>
> pre-extract:
> .if defined(WITH_IPV6)
> .undef WITH_IPV6
> =A0@${ECHO_MSG} "********************************************************=
*************"
> =A0@${ECHO_MSG} "*** IPV6 IS NOT ENABLED FOR net/fping, IT DOES NOT WORK =
WITH IPV4 ***"
> =A0@${ECHO_MSG} "*** =A0 =A0 =A0 =A0 =A0 =A0 PLEASE SEE/USE net/fping+ipv=
6 INSTEAD =A0 =A0 =A0 =A0 =A0 =A0 ***"
> =A0@${ECHO_MSG} "*** =A0 =A0THESE PORTS CAN CO-EXIST TOGETHER AND BOTH BE=
INSTALLED =A0 =A0***"
> =A0@${ECHO_MSG} "********************************************************=
*************"
> =A0@sleep 10
> .endif
>
I would suggest the following changes for net/fping:
- remove the ipv6 category from net/fping, since it is ipv4 only.
Change comment to:
COMMENT=3D Quickly ping N hosts w/o flooding the network - IPv4 Only versio=
n
- Remove this define from the ports Makefile:
.if defined(WITH_IPV6)
# IPv6 not enabled by default, as it does not work together with IPv4.
CFLAGS+=3D -DIPV6
.endif
I also noticed that the net/fping includes a source address patch
(net/fping/files/patch-sourceaddr) that is missing in the
net/fping+ipv6 port. The patch seems to support both ipv4 or ipv6
depending on if IPV6 is defined.
Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimB5V=jDUOxXbLoiuA2UsnP6TnZNA>