Date: Mon, 14 Aug 2006 15:52:52 +0300 (EEST) From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> To: Andrey Chernov <ache@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Ruslan Ermilov <ru@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/groff/tmac Makefile Message-ID: <20060814154640.R28464@atlantis.atlantis.dp.ua> In-Reply-To: <20060814124528.GB28932@nagual.pp.ru> References: <200608141221.k7ECLwHq069066@repoman.freebsd.org> <20060814124528.GB28932@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello! On Mon, 14 Aug 2006, Andrey Chernov wrote: >> - Touch /usr/share/tmac/man.local if it already exists. > > It is definitely bad habbit touching the files to marking them not > obsoleted. Many developers including me use 'INSTALL = install -C' which > not touch files when not needed, so we have correct date of the actual > last file change. With that your touching those files will falsely looks > updated. Please back it out. Note that this commit does _not_ touch the file. As I've shown in my previous letter, ':>>$file' will _not_ change file's modification time. Maybe, we should avoid spelling ':>>' as a 'touch' in the commit log to prevent such a confusion? BTW, knowing that ':>>$file' doesn't change modification time, I'm really curiuos what this ".else / :>> / .endif" really does? Isn't this a plain NOOP?! Sincerely, Dmitry -- Atlantis ISP, System Administrator e-mail: dmitry@atlantis.dp.ua nic-hdl: LYNX-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060814154640.R28464>