Date: Sun, 20 Sep 1998 18:51:57 +0200 (CEST) From: Stefan Eggers <seggers@semyam.dinoco.de> To: FreeBSD-gnats-submit@FreeBSD.ORG Cc: seggers@semyam.dinoco.de Subject: bin/7998: pkg_add seems to have unneeded umask Message-ID: <199809201651.SAA01653@semyam.dinoco.de>
next in thread | raw e-mail | index | archive | help
>Number: 7998
>Category: bin
>Synopsis: pkg_add seems to have unneeded umask
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 20 10:30:00 PDT 1998
>Last-Modified:
>Originator: Stefan Eggers
>Organization:
none
>Release: FreeBSD 3.0-BETA i386
>Environment:
-current from today.
>Description:
pkg_add's perform.c seems to have an unnecessary umask call in
it. This sets the umask to 022 before registering the new package.
As it is already 022 due to the umask in main() introduced in 1.18 on
September 14 I think this one can be removed.
>How-To-Repeat:
>Fix:
Untested as I don't think it is wise to change the sources
while a buildworld is working on it and I have to catch up with
reading the commit logs. ;-)
--- /usr2/FreeBSD/src/usr.sbin/pkg_install/add/perform.c Sun Sep 13 14:42:13 1998
+++ perform.c Sun Sep 20 18:46:16 1998
@@ -366,7 +366,6 @@
char contents[FILENAME_MAX];
FILE *cfile;
- umask(022);
if (getuid() != 0)
warnx("not running as root - trying to record install anyway");
if (!PkgName) {
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809201651.SAA01653>