Date: Fri, 24 Apr 2026 16:39:06 -0400 From: "Drew Gallatin" <gallatin@freebsd.org> To: "Andrew Gallatin" <gallatin@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5923b363ca61 - main - net: Fix collision between SIOCGI2CPB and IPSECGREQID Message-ID: <e624de68-b2c0-4f5b-b1cc-100903218a1d@app.fastmail.com> In-Reply-To: <69ebd2f6.37611.54446236@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Apr 24, 2026, at 4:30 PM, Andrew Gallatin wrote: > The branch main has been updated by gallatin: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5923b363ca616e7cd4fdec1f4f0bf0c98b272468 > > commit 5923b363ca616e7cd4fdec1f4f0bf0c98b272468 > Author: Andrew Gallatin <gallatin@FreeBSD.org> > AuthorDate: 2026-04-24 20:01:44 +0000 > Commit: Andrew Gallatin <gallatin@FreeBSD.org> > CommitDate: 2026-04-24 20:30:24 +0000 > > net: Fix collision between SIOCGI2CPB and IPSECGREQID > > It turns out interface ioctls are defined not just in sockio.h, but are > spread among many files. When I added SIOCGI2CPB at the bottom of the > file, the next number (160) collided with an ioctl (IPSECGREQID) that > I was unaware of in another file. Fix this by moving to a number that > is unclaimed. > > Fixes: cf1f21572897 (net: Add SIOCGI2CPB ioctl & add page/bank fields to ifi2creq) > Reported by: dhw > Reviewed by: imp > Note that the main consequence of this collision is mce whining in dmesg, so I didn't feel it warranted a FreeBSD version bump. [-- Attachment #2 --] <!DOCTYPE html><html><head><title></title></head><body><div><br></div><div><br></div><div>On Fri, Apr 24, 2026, at 4:30 PM, Andrew Gallatin wrote:</div><blockquote type="cite" id="qt" style=""><div>The branch main has been updated by gallatin:</div><div><br></div><div>URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=5923b363ca616e7cd4fdec1f4f0bf0c98b272468">https://cgit.FreeBSD.org/src/commit/?id=5923b363ca616e7cd4fdec1f4f0bf0c98b272468</a></div><div><br></div><div>commit 5923b363ca616e7cd4fdec1f4f0bf0c98b272468</div><div>Author: Andrew Gallatin <<a href="mailto:gallatin@FreeBSD.org">gallatin@FreeBSD.org</a>></div><div>AuthorDate: 2026-04-24 20:01:44 +0000</div><div>Commit: Andrew Gallatin <<a href="mailto:gallatin@FreeBSD.org">gallatin@FreeBSD.org</a>></div><div>CommitDate: 2026-04-24 20:30:24 +0000</div><div><br></div><div> net: Fix collision between SIOCGI2CPB and IPSECGREQID</div><div> </div><div> It turns out interface ioctls are defined not just in sockio.h, but are</div><div> spread among many files. When I added SIOCGI2CPB at the bottom of the</div><div> file, the next number (160) collided with an ioctl (IPSECGREQID) that</div><div> I was unaware of in another file. Fix this by moving to a number that</div><div> is unclaimed.</div><div> </div><div> Fixes: cf1f21572897 (net: Add SIOCGI2CPB ioctl & add page/bank fields to ifi2creq)</div><div> Reported by: dhw</div><div> Reviewed by: imp</div><div><br></div></blockquote><div><br></div><div>Note that the main consequence of this collision is mce whining in dmesg, so I didn't feel it warranted a FreeBSD version bump. </div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e624de68-b2c0-4f5b-b1cc-100903218a1d>