Date: Tue, 8 Sep 2009 14:43:11 -0500 From: Brooks Davis <brooks@FreeBSD.org> To: Bruce Cran <bruce@cran.org.uk> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r195843 - in head: lib/libkvm sys/kern sys/sys Message-ID: <20090908194311.GB32690@lor.one-eyed-alien.net> In-Reply-To: <20090906044700.5208ba62@gluon.draftnet> References: <200907241503.n6OF3ATP013228@svn.freebsd.org> <20090829201228.00005860@unknown> <20090904221432.GC82231@lor.one-eyed-alien.net> <20090906044700.5208ba62@gluon.draftnet>
next in thread | previous in thread | raw e-mail | index | archive | help
--pvezYHf7grwyp3Bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 06, 2009 at 04:47:00AM +0100, Bruce Cran wrote: > On Fri, 4 Sep 2009 17:14:32 -0500 > Brooks Davis <brooks@FreeBSD.org> wrote: >=20 > > On Sat, Aug 29, 2009 at 08:12:28PM +0100, Bruce Cran wrote: > > > On Fri, 24 Jul 2009 15:03:10 +0000 (UTC) > > > Brooks Davis <brooks@FreeBSD.org> wrote: > > >=20 > > > > Author: brooks > > > > Date: Fri Jul 24 15:03:10 2009 > > > > New Revision: 195843 > > > > URL: http://svn.freebsd.org/changeset/base/195843 > > > >=20 > > > > Log: > > > > Revert the changes to struct kinfo_proc in r194498. Instead, > > > > fill in up to 16 (KI_NGROUPS) values and steal a bit from > > > > ki_cr_flags (all bits currently unused) to indicate overflow with > > > > the new flag KI_CRF_GRP_OVERFLOW. > > > > =20 > > > > This fixes procstat -s. > > > > =20 > > > > Approved by: re (kib) > > >=20 > > > Hi Brooks, > > >=20 > > > This checkin appears to have broken crash dump support: the bcopy in > > > kvm_proc.c crashes when running "ps -ax -M /var/crash/vmcore.x > > > -N /boot/kernel/kernel", apparently because ucred.cr_groups isn't > > > valid. Does it need converted using KVM_READ first? > >=20 > > Sorry for the delay, I believe you are correct we need to use kvm_read > > here instead of the bcopy. Do you still have a core handy you can > > test a patch against? The following should do it. >=20 > The patch has fixed the crash, and data is now returned too. Thanks for testing! I've committed the patch and will MFC in the next week or so. -- Brooks --pvezYHf7grwyp3Bc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKprPOXY6L6fI4GtQRAlpVAKCmyIq5Pttd5EDXtpTfzqv2d037vACgvYbn uiFQ9oKfoKCAnzcL6HNJjZU= =9/4F -----END PGP SIGNATURE----- --pvezYHf7grwyp3Bc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090908194311.GB32690>