Date: Wed, 29 Apr 2026 07:31:25 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Daniel Engberg <diizzy@freebsd.org> Cc: Gleb Popov <arrowd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 70718cbf1b00 - main - Mk/Uses/meson.mk: Silence warning during do-configure stage Message-ID: <tij7jltpcluq632mou52qyx77mlopobe5l6pchig4hyt3vtwzo@6o6xw22gptgb> In-Reply-To: <66ff8588-89bb-49ec-a208-7a7d3e2e42b7@FreeBSD.org> References: <69f0fbce.202f4.25de3156@gitrepo.freebsd.org> <CALH631nrefU_s_rJ%2B-ChEzR1SVbmF7K8nDrO7wNKk4_8u-5uOw@mail.gmail.com> <66ff8588-89bb-49ec-a208-7a7d3e2e42b7@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Apr 28, 2026 at 09:21:40PM +0200, Daniel Engberg wrote: > On 2026-04-28 20:50, Gleb Popov wrote: > > On Tue, Apr 28, 2026 at 9:26 PM Daniel Engberg <diizzy@freebsd.org> wrote: > > > > > > PR: 294808 > > > Reviewed by: desktop (arrowd), previous interation > > > > desktop@ did not give you approval on this iteration, nor approved > > bf193dc1da282c769d3291817a8378adbd762ac7 and you didn't wait even 3 > > days to give me a chance to review this. > > > > But I'm too tired to fight you, so I'm letting portmgr to chime in if > > they are interested. > > Hi, > > The only difference is that the framework Daniel, Regardless of the scope of the change, any modification to the framework requires explicit approval from the relevant maintainers before being committed. 'Previous iteration' does not constitute approval for a new iteration. This is not a matter of whether the change is correct or not, it is a matter of process, and that process exists for good reason. Going forward, please make sure to obtain explicit approval on each iteration before committing, regardless of how minor the differences may seem -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmnxl61fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb555gv+NNjfww3jLUq/z2HqtUWMRP0+EhEIB4PUHX1maIW6FHP6u2OqlkqX7TiX dXXtTSWUiO/AA9MvfxoyOqNLSBu4pI8Cdnt4oggnYocZ/yjLunipTK4HiRRcSGQc JLXEoStVWdNOSmCJn9JtmgQXq3PM46OHnshk+VeficVoFN7H5+A5XvGGCuiLxXGi FSoDB2lv/L6QXWqGTt/kLA8dXBQJ518sUiApxQKzmN8rqKk86YCKVN038QI6dDt/ C+KboYiqAifrjj/jlawFBQhQZJnN1NJxW7CWT9BXj6C6fK+LLPS0i+8XBwXMC+C1 Ocsj6ABl/bPkub49XP8fnv8d7vnXluwCwdoeK4M0x6gQc8WBzt65iEsXrBnmybvZ 72g3rPaddoYCc5ddXmxkN25PeKDdkMc6RSPNCBUkfwUowiOT3tf7Ydi1gQ6KLwH1 BPqTggxAf8ak7SZS/57eGrxr5h3KAZz/sjTxXPrW1CS05fkFmPHDEIs+tULgYfws N0JaM8W2 =7k1H -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?tij7jltpcluq632mou52qyx77mlopobe5l6pchig4hyt3vtwzo>